Commits · 27b900a50f37b89fb66b2fa2c49c3a531eab8af8 · Jérome Perrin / neoppod

30 Sep, 2009 12 commits

Use anytime is possible the is<State>() and set<State> available in Node class. · 27b900a5

Grégory Wisniewski authored Sep 30, 2009

Remove all (now useless) imports from protocol module.


git-svn-id: https://svn.erp5.org/repos/neo/trunk@1327 71dcc9de-d417-0410-9af5-da40c76e7ee4

27b900a5

Add isIdentified() on Node class that check if an UUID is set on this node. The · 71e1beef

Grégory Wisniewski authored Sep 30, 2009

purpose is to replace the so often used <node.getUUID() is not None> pattern.


git-svn-id: https://svn.erp5.org/repos/neo/trunk@1326 71dcc9de-d417-0410-9af5-da40c76e7ee4

71e1beef

Add set<state> and is<state> helper methods in Node class to avoid many imports · eb810f88

Grégory Wisniewski authored Sep 30, 2009

from protocol module and clarify the source code. Those definitions will be
gradualy used everywhere in NEO.

git-svn-id: https://svn.erp5.org/repos/neo/trunk@1325 71dcc9de-d417-0410-9af5-da40c76e7ee4

eb810f88

Each time a unknown node is registered into the manager, the state is defaulted · 0d1c4b07
Grégory Wisniewski authored Sep 30, 2009
```
to 'UNKNOWN'.


git-svn-id: https://svn.erp5.org/repos/neo/trunk@1324 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
0d1c4b07

Change NodeManager.log() implementation, display one node per line with (or · 9111aa13

Grégory Wisniewski authored Sep 30, 2009

without) it's UUID and bind address if available. Implement '__gt__' to sort
nodes per UUID by default.
Reduce log verbosity by displaying nodes only one time per manager update.

git-svn-id: https://svn.erp5.org/repos/neo/trunk@1323 71dcc9de-d417-0410-9af5-da40c76e7ee4

9111aa13

Fix method name. · cc2d5e26

Grégory Wisniewski authored Sep 30, 2009


git-svn-id: https://svn.erp5.org/repos/neo/trunk@1322 71dcc9de-d417-0410-9af5-da40c76e7ee4

cc2d5e26

Remove unused imports. · 4eeabcbf

Grégory Wisniewski authored Sep 30, 2009


git-svn-id: https://svn.erp5.org/repos/neo/trunk@1321 71dcc9de-d417-0410-9af5-da40c76e7ee4

4eeabcbf

To follows changes in r1317, replace 'server' by 'address' for consistency. · 8e2b08de
Grégory Wisniewski authored Sep 30, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1320 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
8e2b08de
As for previous commit, replace calls of getXXXNodeList() with getXXXList(). · 36555d9a
Grégory Wisniewski authored Sep 30, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1319 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
36555d9a
Replace calls of 'getNodeByXXX' with 'getByXXX' because 'Node' is implied by the · 57e5e7f8
Grégory Wisniewski authored Sep 30, 2009
```
node manager.


git-svn-id: https://svn.erp5.org/repos/neo/trunk@1318 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
57e5e7f8

Partial rewrite of Node and NodeManager classes: · 86819c9c

Grégory Wisniewski authored Sep 30, 2009

* Manager now index per node type and node state
* Use set() instead of list() to ensure node unicity
* Rename 'server' attribute to 'address' for consistency
* Remove 'filter' parameter from clear(), because it's never used.
* Update tests 


git-svn-id: https://svn.erp5.org/repos/neo/trunk@1317 71dcc9de-d417-0410-9af5-da40c76e7ee4

86819c9c

Remove useless imports. · 053eaa8b

Grégory Wisniewski authored Sep 30, 2009


git-svn-id: https://svn.erp5.org/repos/neo/trunk@1316 71dcc9de-d417-0410-9af5-da40c76e7ee4

053eaa8b

29 Sep, 2009 4 commits

Remove useless checks (already done in registerXXX()) · 340e7808
Grégory Wisniewski authored Sep 29, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1315 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
340e7808
Use isMaster() instead of check the node type. · 3ee69f4e
Grégory Wisniewski authored Sep 29, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1314 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
3ee69f4e

Remove manager getter/setter from Node class and require it in the constructor · dd02fa4c

Grégory Wisniewski authored Sep 29, 2009

since a node must always be registered to the manager. Remove *args parameters,
positional arguments are no more allowed for node creation.
Fix wrong definition of dict in createFromNodeType.

git-svn-id: https://svn.erp5.org/repos/neo/trunk@1313 71dcc9de-d417-0410-9af5-da40c76e7ee4

dd02fa4c

Add create<NodeType> methods on the NodeManager, now node creation is only done · 68835978

Grégory Wisniewski authored Sep 29, 2009

through those methods and node registration is automatic. There is no more need
to import Node classes directly, so remove all related imports.

git-svn-id: https://svn.erp5.org/repos/neo/trunk@1312 71dcc9de-d417-0410-9af5-da40c76e7ee4

68835978

24 Sep, 2009 1 commit
- Use class-check to known the node type. · 76671a6f
  Grégory Wisniewski authored Sep 24, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1311 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
  76671a6f
23 Sep, 2009 4 commits

Use path, test class and test method when displaying a failed test report to · dd38109e

Grégory Wisniewski authored Sep 23, 2009

allow copy/paste them and launch the test again.


git-svn-id: https://svn.erp5.org/repos/neo/trunk@1310 71dcc9de-d417-0410-9af5-da40c76e7ee4

dd38109e

Fix some tests, move some others and delete some useless too. · 7f033f3c
Grégory Wisniewski authored Sep 23, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1309 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
7f033f3c
Rewrite dispatcher (now generic) tests. · f7652c07
Grégory Wisniewski authored Sep 23, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1308 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
f7652c07

Fix some tests. · 235fdc88

Grégory Wisniewski authored Sep 23, 2009


git-svn-id: https://svn.erp5.org/repos/neo/trunk@1307 71dcc9de-d417-0410-9af5-da40c76e7ee4

235fdc88

22 Sep, 2009 14 commits

Commit after setup databases to ensure they are available for processes. · 8fdfe307
Grégory Wisniewski authored Sep 22, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1306 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
8fdfe307

Fix some tests: · bfd9ef0c

Grégory Wisniewski authored Sep 22, 2009

- service.handleAskBeginTransaction now requires TID parameter
- when identifying a node, build the right node class


git-svn-id: https://svn.erp5.org/repos/neo/trunk@1305 71dcc9de-d417-0410-9af5-da40c76e7ee4

bfd9ef0c

Fix many tests, mainly for storage application. They still need a full review to · aa52f9b6

Grégory Wisniewski authored Sep 22, 2009

ensure all is well tested and that there is no redondancy.


git-svn-id: https://svn.erp5.org/repos/neo/trunk@1304 71dcc9de-d417-0410-9af5-da40c76e7ee4

aa52f9b6

Avoid an infinite loop when strating the cluster (wmhen waiting for storages). · 6f3d9187
Grégory Wisniewski authored Sep 22, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1303 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
6f3d9187
Wrap lines at 80 characters in the TODO file. · 45b0ddc2
Grégory Wisniewski authored Sep 22, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1302 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
45b0ddc2

Decrease master election timeout, there is no reasons to not take one of the · b1c4cb6c

Grégory Wisniewski authored Sep 22, 2009

first master up as primary, then accept the others (lowest) as secondaries.


git-svn-id: https://svn.erp5.org/repos/neo/trunk@1301 71dcc9de-d417-0410-9af5-da40c76e7ee4

b1c4cb6c

Minor fixed in functionnal tests: · 011b1d5c

Grégory Wisniewski authored Sep 22, 2009

- Clear the databases before the cluster is created (and storages started) to
avoid the latter load a false configuration.
- Ensure replication is done before drop a node in storage tests.
- Admin node take the first allocated port for consistency.


git-svn-id: https://svn.erp5.org/repos/neo/trunk@1300 71dcc9de-d417-0410-9af5-da40c76e7ee4

011b1d5c

Fix inconsistency in handleAnswerStoreObject method definitions, parameter list · 9e863896
Grégory Wisniewski authored Sep 22, 2009
```
defined in API (handler.py) was wrong.


git-svn-id: https://svn.erp5.org/repos/neo/trunk@1299 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
9e863896

PFix missing import. · 0e377745

Grégory Wisniewski authored Sep 22, 2009


git-svn-id: https://svn.erp5.org/repos/neo/trunk@1298 71dcc9de-d417-0410-9af5-da40c76e7ee4

0e377745

Add a packet logger for custom and fine-grained debugging messages. · 58c82e3b
Grégory Wisniewski authored Sep 22, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1297 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
58c82e3b
Partial revert of previous commit, some files were commited by error, sorry. · dff0efea
Grégory Wisniewski authored Sep 22, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1296 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
dff0efea
Change default neoadmin port in neoctl to match with the default value in · aa4ed196
Grégory Wisniewski authored Sep 22, 2009
```
neoadmin.


git-svn-id: https://svn.erp5.org/repos/neo/trunk@1295 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
aa4ed196
Handle the case where no password is supplied in the database connection string. · c58318c5
Grégory Wisniewski authored Sep 22, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1294 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
c58318c5
Handle the case where no master a supplied with the --masters command line · bf49374b
Grégory Wisniewski authored Sep 22, 2009
```
parameter.


git-svn-id: https://svn.erp5.org/repos/neo/trunk@1293 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
bf49374b

21 Sep, 2009 5 commits

Remove bad old tests for the (recently generic) bootstrap module. · 79fb4775
Grégory Wisniewski authored Sep 21, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1292 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
79fb4775
Remove configuration file related code in functional tests framework. · 082fd787
Grégory Wisniewski authored Sep 21, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1291 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
082fd787
Full rewrite of node module tests, better fit to the actual implementation of · d7bfc065
Grégory Wisniewski authored Sep 21, 2009
```
Node and NodeManager classes.


git-svn-id: https://svn.erp5.org/repos/neo/trunk@1290 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
d7bfc065

Factorise split of master node list from command line. Now use '/' as · b839b14e

Grégory Wisniewski authored Sep 21, 2009

separator for master addresses list instead of a space to be more shell friendly
(no more need to surround the argument with quotes, easier for remote commands).


git-svn-id: https://svn.erp5.org/repos/neo/trunk@1289 71dcc9de-d417-0410-9af5-da40c76e7ee4

b839b14e

Improve error log message. · 60fc3f82

Grégory Wisniewski authored Sep 21, 2009


git-svn-id: https://svn.erp5.org/repos/neo/trunk@1288 71dcc9de-d417-0410-9af5-da40c76e7ee4

60fc3f82