Commits · 40fc5505f8ca01095380a9d58bc436e628c1177d · Jérome Perrin / neoppod

26 Jan, 2010 1 commit
- Replace 'while 1' statements with 'while True'. · 40fc5505
  Grégory Wisniewski authored Jan 26, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1495 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
  40fc5505
22 Jan, 2010 29 commits

Fix test for finishTransaction(), partition table was not initialized. · 82f27499
Grégory Wisniewski authored Jan 22, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1494 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
82f27499
A little bit dirty but this avoid the special case 'None' and fix the test. · 8a9c18b4
Grégory Wisniewski authored Jan 22, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1493 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
8a9c18b4
Replace failUnless() with assertTrue() · 5cb770e5
Grégory Wisniewski authored Jan 22, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1492 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
5cb770e5
Storage node must never send this packet, even during recovery, so remove this test case. · af374f83
Grégory Wisniewski authored Jan 22, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1491 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
af374f83
Rename UnlockInformation to NotifyUnlockInformation. · f82331fc
Grégory Wisniewski authored Jan 22, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1490 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
f82331fc
Rename NotifyTransactionFinished to AnswerTransactionFinished as it's not a notification. · d3f3067e
Grégory Wisniewski authored Jan 22, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1489 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
d3f3067e
Rewrite and split of notifyInformationLocked test. · 0ffd912e
Grégory Wisniewski authored Jan 22, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1488 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
0ffd912e
Add missing helper function in test case. · ec5efd5b
Grégory Wisniewski authored Jan 22, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1487 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
ec5efd5b
Add helper methods to create nodes for testing purpose. · f61b7fd5
Grégory Wisniewski authored Jan 22, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1486 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
f61b7fd5

Fix packet kind in base test case. · 56bcf0c6

Grégory Wisniewski authored Jan 22, 2010

NotifyTransactionFinished is misspelled, it is an answer packet.
Similary, UnlockInformation is a notification, not a request.

git-svn-id: https://svn.erp5.org/repos/neo/trunk@1485 71dcc9de-d417-0410-9af5-da40c76e7ee4

56bcf0c6

Remove 'master_node_list' attribute on apps. · b7f4fbba

Grégory Wisniewski authored Jan 22, 2010

There is no need to store the master address list out of the node manager, any master found in configuration is loaded in the node manager and can be retreived by it if needed.
Remove redundant intialization code in test module, master nodes are created at app initialization.

git-svn-id: https://svn.erp5.org/repos/neo/trunk@1484 71dcc9de-d417-0410-9af5-da40c76e7ee4

b7f4fbba

The filter parameter is nor used neither implemented, remove it. · 6cdbf741
Grégory Wisniewski authored Jan 22, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1483 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
6cdbf741
This attribute no more exists in master's app since transaction manager creation. · 8f6bdebd
Grégory Wisniewski authored Jan 22, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1482 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
8f6bdebd
Fix NotifyNodeInformation docstring, only master node send this packet. · 6c192465
Grégory Wisniewski authored Jan 22, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1481 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
6c192465
The client never send this packet too. · efbd4da1
Grégory Wisniewski authored Jan 22, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1480 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
efbd4da1
Add an helper method to generate OIDs in test cases. · 821efe8d
Grégory Wisniewski authored Jan 22, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1479 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
821efe8d
This packet has been replaced by the (simpler) notifyReplicationDone (Test required). · c9619d9d
Grégory Wisniewski authored Jan 22, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1478 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
c9619d9d

A storage must never send this packet to the master node. The master has a... · ec3af08c

Grégory Wisniewski authored Jan 22, 2010

A storage must never send this packet to the master node. The master has a view of all nodes and detect itself any breakage.

git-svn-id: https://svn.erp5.org/repos/neo/trunk@1477 71dcc9de-d417-0410-9af5-da40c76e7ee4

ec3af08c

Fit better with the implementation, when a node is identified to the master,... · de257d64

Grégory Wisniewski authored Jan 22, 2010

Fit better with the implementation, when a node is identified to the master, it got an entry in the node manager.

git-svn-id: https://svn.erp5.org/repos/neo/trunk@1476 71dcc9de-d417-0410-9af5-da40c76e7ee4

de257d64

Master's now handle connection failures during recovery. · 809fce71

Grégory Wisniewski authored Jan 22, 2010

This behaviour was probably lost with the master's handler split and was found by fixing unit tests.
During recovery, if a node is lost it's state is updated but not propagated to other (storages) nodes because after the recovery they will all retreive the whole node list.

git-svn-id: https://svn.erp5.org/repos/neo/trunk@1475 71dcc9de-d417-0410-9af5-da40c76e7ee4

809fce71

Send an error to the storage node if the partition table sent is invalid... · 39544c84

Grégory Wisniewski authored Jan 22, 2010

Send an error to the storage node if the partition table sent is invalid instead of killing the master.

git-svn-id: https://svn.erp5.org/repos/neo/trunk@1474 71dcc9de-d417-0410-9af5-da40c76e7ee4

39544c84

Replace an assert with raise of IndexError exception when loading a partition with bad offsets. · 08d0e27f
Grégory Wisniewski authored Jan 22, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1473 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
08d0e27f
Nodes are initialy in unknown state since r1192, fix tests. · 2c0bf157
Grégory Wisniewski authored Jan 22, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1472 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
2c0bf157
Fix tests using broadcastNodeInformation, broken since r1451. · 60700d00
Grégory Wisniewski authored Jan 22, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1471 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
60700d00
Minor cosmetic changes in test runner. · 28182c79
Grégory Wisniewski authored Jan 22, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1470 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
28182c79

Remove try/except block that hide an exception without explanations. · b5b72ac8

Grégory Wisniewski authored Jan 22, 2010

KeyError may be raised from many statements here, the try/except give no indications.
Also reduce block indentation for readability and add some comments.

git-svn-id: https://svn.erp5.org/repos/neo/trunk@1469 71dcc9de-d417-0410-9af5-da40c76e7ee4

b5b72ac8

Use NotifyReplicatioDone packet. · efc8a8ec

Grégory Wisniewski authored Jan 22, 2010

git-svn-id: https://svn.erp5.org/repos/neo/trunk@1468 71dcc9de-d417-0410-9af5-da40c76e7ee4

efc8a8ec

Add notifyReplicationDone packet. · fd4a9b16

Grégory Wisniewski authored Jan 22, 2010

This packet replace notifyPartitionChange when used by storage's replicator at the end of a single partition replication.
In those case, only one partition was involved and the node concerned must match with the sender identify, causing many useless on the master side.
This packet contains only the partition number that is replicated and implies that the node's cell is now up to date.
It should be sent only by the storage node from replicator and received by master node.

git-svn-id: https://svn.erp5.org/repos/neo/trunk@1467 71dcc9de-d417-0410-9af5-da40c76e7ee4

fd4a9b16

Those private one-line methods are used only once, remove them. · 1265b4c9
Grégory Wisniewski authored Jan 22, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1466 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
1265b4c9

21 Jan, 2010 8 commits
- This work was done in r1350. · 7f317b09
  Grégory Wisniewski authored Jan 21, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1465 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
  7f317b09
- Add support of name resolution to allow use of hostname instead of IPs in configuration. · 5694ed93
  Grégory Wisniewski authored Jan 21, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1464 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
  5694ed93
- Split election process into shorter methods to highlight logic. · b079ca14
  Grégory Wisniewski authored Jan 21, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1463 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
  b079ca14
- Give tuple argument to '%' operator. Also add 'uuid' in storage log for consistency. · 651e51b3
  Grégory Wisniewski authored Jan 21, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1462 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
  651e51b3
- Use a real TID in test. · 14ab1972
  Grégory Wisniewski authored Jan 21, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1461 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
  14ab1972
- Define get<NodeType>UUID in base test class to fit better with implementation. · 57a219d6
  Grégory Wisniewski authored Jan 21, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1460 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
  57a219d6
- All FIXMEs are reviewed, remove this job from TODO-file. · a41b720e
  Grégory Wisniewski authored Jan 21, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1459 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
  a41b720e
- Convert some TODOs in XXXs. · fafff38d
  Grégory Wisniewski authored Jan 21, 2010
```
git-svn-id: https://svn.erp5.org/repos/neo/trunk@1458 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
  fafff38d
20 Jan, 2010 2 commits

Remove unused imports. · e93492cc

Grégory Wisniewski authored Jan 20, 2010

git-svn-id: https://svn.erp5.org/repos/neo/trunk@1457 71dcc9de-d417-0410-9af5-da40c76e7ee4

e93492cc

Update tests according to previous commit. · 393ebf73

Grégory Wisniewski authored Jan 20, 2010

- testUtil module is now empty, but kept for futur tests.
- NeoTestBase got a new getNextTID() method with a copy/paste from master's transactions manager to generate TIDs.
- testProtocol module no more import getNextTID() from neo.util module
- testTransactions test module is updated to test new features provides by transactions manager.

git-svn-id: https://svn.erp5.org/repos/neo/trunk@1456 71dcc9de-d417-0410-9af5-da40c76e7ee4

393ebf73