Commits · d50e53a8c776ee7f84cc8612316d0d43a89faeab · Jérome Perrin / neoppod

01 Apr, 2009 8 commits

Replace an "*" import by one explicitely stating what it needs to import. · d50e53a8
Vincent Pelletier authored Apr 01, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@310 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
d50e53a8

Initial import of ClientHandler class unit test. · c0335216

Vincent Pelletier authored Apr 01, 2009

Note: there are 3 unimplemented tests (raising NotImplementedError).
test_StopOperation: looks unimplemented in current code (no action besides logging).
test_knownMasterNotifyNodeInformation & test_unknownMasterNotifyNodeInformation: it is yet unsure on how to test those cases.

git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@309 71dcc9de-d417-0410-9af5-da40c76e7ee4

c0335216

Remove a duplicate assignment to app local variable. · 358f593c
Vincent Pelletier authored Apr 01, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@308 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
358f593c

Remove all "isinstance(conn, MTClientConnection)" tests from client handler to... · 3593c1aa

Vincent Pelletier authored Apr 01, 2009

Remove all "isinstance(conn, MTClientConnection)" tests from client handler to make it unit-test-friendly: Client node does not have any listening socket, so there cannot be any (MT)ServerConnection instance used to reach handler. Also, Multi-Thread safety is not a runtime but a static criterion (ie, it is most likely a bug to use non-multi-thread-safe Connection subclasses in client). So this test is an always-true check, and can be removed.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@307 71dcc9de-d417-0410-9af5-da40c76e7ee4

3593c1aa

There is no need for a client node to retain information on the status of other client nodes. · 241b4eb2
Vincent Pelletier authored Apr 01, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@306 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
241b4eb2

Change "if" into "elif": it is obviously wrong to call... · 511433ca

Vincent Pelletier authored Apr 01, 2009

Change "if" into "elif": it is obviously wrong to call app.master_conn.getUUID() on None, so this test should only be executed in "not None" case.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@305 71dcc9de-d417-0410-9af5-da40c76e7ee4

511433ca

Commit 303 removed an implicit check againt NoneType. Restore it explicitely. · 9c56ea85
Vincent Pelletier authored Apr 01, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@304 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
9c56ea85

Replace isinstance(node, ...Node) by node.getNodeType() == ..._NODE_TYPE (and... · dfee4fcc

Vincent Pelletier authored Apr 01, 2009

Replace isinstance(node, ...Node) by node.getNodeType() == ..._NODE_TYPE (and similar). This makes things easier to unit test.
Add missing imports.

git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@303 71dcc9de-d417-0410-9af5-da40c76e7ee4

dfee4fcc

31 Mar, 2009 3 commits

do not hardcode the value everywhere, use a global variable instead · 47d42d56
Aurel authored Mar 31, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@302 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
47d42d56

check manager is not None before calling it · 6fa4ebc3

Aurel authored Mar 31, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@301 71dcc9de-d417-0410-9af5-da40c76e7ee4

6fa4ebc3

add unit test for partition table · fd0506e7

Aurel authored Mar 31, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@300 71dcc9de-d417-0410-9af5-da40c76e7ee4

fd0506e7

27 Mar, 2009 3 commits

fix variable name · 3065a36a

Aurel authored Mar 27, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@299 71dcc9de-d417-0410-9af5-da40c76e7ee4

3065a36a

same as previous commit but in clear method · c8d119e5

Aurel authored Mar 27, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@298 71dcc9de-d417-0410-9af5-da40c76e7ee4

c8d119e5

use a list comprehension to instantiate list of partition's rows, othersiwe all · 7d75ebaa

Aurel authored Mar 27, 2009

rows are the same rows thanks to implicit pointer


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@297 71dcc9de-d417-0410-9af5-da40c76e7ee4

7d75ebaa

26 Mar, 2009 8 commits

add unit test for configuration manager · de0813cd

Aurel authored Mar 26, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@296 71dcc9de-d417-0410-9af5-da40c76e7ee4

de0813cd

defined connector in default config · afc808af

Aurel authored Mar 26, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@295 71dcc9de-d417-0410-9af5-da40c76e7ee4

afc808af

add a test for nodes and nodes manager · e5755b0c

Aurel authored Mar 26, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@294 71dcc9de-d417-0410-9af5-da40c76e7ee4

e5755b0c

remove dead code as we can't have a client node connected at this step · dc46f688
Aurel authored Mar 26, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@293 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
dc46f688

add a test for the verification handler · ccd1e781

Aurel authored Mar 26, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@292 71dcc9de-d417-0410-9af5-da40c76e7ee4

ccd1e781

remove unused patch · 5a9a5d56

Aurel authored Mar 26, 2009

fix class name


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@291 71dcc9de-d417-0410-9af5-da40c76e7ee4

5a9a5d56

Revert commit 252: connection is sent to dispatcher via registration, so it's safer to lock it. · 18226f49
Vincent Pelletier authored Mar 26, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@290 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
18226f49

Revert commit 254: super(MTClientConnection, self).__init__ sends self to... · d04c53f2

Vincent Pelletier authored Mar 26, 2009

Revert commit 254: super(MTClientConnection, self).__init__ sends self to event_manager, which registers it to epoll, and epoll_wait is pending in another thread. So this lock is really needed.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@289 71dcc9de-d417-0410-9af5-da40c76e7ee4

d04c53f2

25 Mar, 2009 11 commits

check that all these messages are sent by a storage node only · c619ca8d

Aurel authored Mar 25, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@288 71dcc9de-d417-0410-9af5-da40c76e7ee4

c619ca8d

one more check · 3ea5e49e

Aurel authored Mar 25, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@287 71dcc9de-d417-0410-9af5-da40c76e7ee4

3ea5e49e

manage case offset is not known · 44c03aa6

Aurel authored Mar 25, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@286 71dcc9de-d417-0410-9af5-da40c76e7ee4

44c03aa6

add test for the recovery handler · b5f92b07

Aurel authored Mar 25, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@285 71dcc9de-d417-0410-9af5-da40c76e7ee4

b5f92b07

fix packet number · 8149cb01

Aurel authored Mar 25, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@284 71dcc9de-d417-0410-9af5-da40c76e7ee4

8149cb01

fix a bad call and missing method · 7856a878

Aurel authored Mar 25, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@283 71dcc9de-d417-0410-9af5-da40c76e7ee4

7856a878

Modify partition table logger to use a more compact format. · 18ecff5f
Vincent Pelletier authored Mar 25, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@282 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
18ecff5f

Use a registry mechanism for Connector instances. · 468227b4

Vincent Pelletier authored Mar 25, 2009

Allow providing non-basestring values as connector parameter, which are then passedthrough as replacements for Connector classes. This is usefull to modify Connector class behaviour in tests.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@281 71dcc9de-d417-0410-9af5-da40c76e7ee4

468227b4

Add lock debugging system on MT(Client|Server)Connection classes. · c2878e99
Vincent Pelletier authored Mar 25, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@280 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
c2878e99

hasOffset must now tests an empty list instead of a None value · 39bd9588

Aurel authored Mar 25, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@279 71dcc9de-d417-0410-9af5-da40c76e7ee4

39bd9588

Move conector handler retrieval code from Storage.py to app.py, to make it... · fbeb6732

Vincent Pelletier authored Mar 25, 2009

Move conector handler retrieval code from Storage.py to app.py, to make it consistent with other nodes.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@278 71dcc9de-d417-0410-9af5-da40c76e7ee4

fbeb6732

24 Mar, 2009 7 commits

import connectors from tests · 1b35133a

Aurel authored Mar 24, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@277 71dcc9de-d417-0410-9af5-da40c76e7ee4

1b35133a

Disable timeout in this loop: it is only here to wait for packets, so it has no reason to timeout. · 99338aba
Vincent Pelletier authored Mar 24, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@276 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
99338aba
Add the possibility in epoll to disable timeout in a python's select compatible way. · 55ae9f31
Vincent Pelletier authored Mar 24, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@275 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
55ae9f31

Remove the need to use a global queue for unexpected messages. They will be... · d16b01f2

Vincent Pelletier authored Mar 24, 2009

Remove the need to use a global queue for unexpected messages. They will be handled in the Dispatcher thread directly, to prevent them from piling up until a client enters app._waitMessage .


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@274 71dcc9de-d417-0410-9af5-da40c76e7ee4

d16b01f2

Fix handler, 3rd try: do not call EventHandler.packetReceived since it will... · 6e45cf77

Vincent Pelletier authored Mar 24, 2009

Fix handler, 3rd try: do not call EventHandler.packetReceived since it will call self.dispatch instead of going through Dispatcher instance.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@273 71dcc9de-d417-0410-9af5-da40c76e7ee4

6e45cf77

On the contrary of what is advertised by python manual, acquire doesn't accept... · 4971ebc8

Vincent Pelletier authored Mar 24, 2009

On the contrary of what is advertised by python manual, acquire doesn't accept any keyword argument...


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@272 71dcc9de-d417-0410-9af5-da40c76e7ee4

4971ebc8

Revert commit r264 and apply a modified version with same intent: "dispatch"... · a2e22eb1

Vincent Pelletier authored Mar 24, 2009

Revert commit r264 and apply a modified version with same intent: "dispatch" method is used as an entry point to ClientEventHandler class, which is called by the thread the packet was dispatched to.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@271 71dcc9de-d417-0410-9af5-da40c76e7ee4

a2e22eb1