Commits · db8450cada1c63cf43bc92884f479df0a8b1586f · Jérome Perrin / neoppod

03 Jul, 2009 18 commits

Fix (some) pyflakes warnings in master and admin node code. · db8450ca
Vincent Pelletier authored Jul 03, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@779 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
db8450ca
Add forgotten replication handler (took from replicator.py). · 122585cf
Grégory Wisniewski authored Jul 03, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@778 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
122585cf

As done for client application, move storage handlers into a dedicated · b75df10f

Grégory Wisniewski authored Jul 03, 2009

directory. Replicator's handler is moved into handlers/replication.py.
Clean some imports.

git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@776 71dcc9de-d417-0410-9af5-da40c76e7ee4

b75df10f

Fix imports to avoid test runner crash. · bfc78394

Grégory Wisniewski authored Jul 03, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@775 71dcc9de-d417-0410-9af5-da40c76e7ee4

bfc78394

Remove all sleeps in testZODB, they are not required any more. · 8c554551
Vincent Pelletier authored Jul 03, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@774 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
8c554551

Big rework on client handlers: · 4c61df28

Vincent Pelletier authored Jul 03, 2009

- Split completely expected packet handlers from asynchronous event handlers
- Remove NEOStorageConnectionFailure exception and replace it by a more general "ConnectionClosed" exception, purely internal to client app.
- Modify waitMessage to redirect to a handler based on remote peer type
- Fix multiple code paths taken when master doesn't accept connections (or closes them) while trying to conenct to it.
Also:
- remove unused imports found by pyflakes


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@773 71dcc9de-d417-0410-9af5-da40c76e7ee4

4c61df28

Remove more unused imports found by pyflakes. · a0f2936c

Vincent Pelletier authored Jul 03, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@772 71dcc9de-d417-0410-9af5-da40c76e7ee4

a0f2936c

Remove unused imports found by pyflakes. · aec0cb00

Vincent Pelletier authored Jul 03, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@771 71dcc9de-d417-0410-9af5-da40c76e7ee4

aec0cb00

One more undefined STORAGE_NODE_TYPE usage (forgotten in Gregosy's recent commit). · e1905079
Vincent Pelletier authored Jul 03, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@770 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
e1905079

Make MTClientConnection.close expect to be called only when protected by a lock. · 9b0b3fb3

Vincent Pelletier authored Jul 03, 2009

Add lock/release around each "close" call in client which wasn't already locked.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@769 71dcc9de-d417-0410-9af5-da40c76e7ee4

9b0b3fb3

Fix attribute name and constant access. · c797d830

Grégory Wisniewski authored Jul 03, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@768 71dcc9de-d417-0410-9af5-da40c76e7ee4

c797d830

Remove a dangling remain of connection message order change. · 6e0075ea
Vincent Pelletier authored Jul 03, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@767 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
6e0075ea

Fix exception name. · a0c8a7d9

Grégory Wisniewski authored Jul 03, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@766 71dcc9de-d417-0410-9af5-da40c76e7ee4

a0c8a7d9

Split client handlers into 3 parts: · a4e7ac97

Vincent Pelletier authored Jul 03, 2009

- generic base handler
- client connection handlers
- master connection handlers


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@765 71dcc9de-d417-0410-9af5-da40c76e7ee4

a4e7ac97

Move handler.py into a separate folder. · b6034e79

Vincent Pelletier authored Jul 03, 2009

Update users.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@764 71dcc9de-d417-0410-9af5-da40c76e7ee4

b6034e79

Replace an "from ... import *" by explicit import list. · d0fa630a
Vincent Pelletier authored Jul 03, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@763 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
d0fa630a

Typo in variable name. · 0f4e1c76

Vincent Pelletier authored Jul 03, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@762 71dcc9de-d417-0410-9af5-da40c76e7ee4

0f4e1c76

Make notifyDeadStorage callable for any kind of node (and rename it to notifyDeadNode). · 02fea1d5

Vincent Pelletier authored Jul 03, 2009

For now, it's a no-op for any non-storage node.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@761 71dcc9de-d417-0410-9af5-da40c76e7ee4

02fea1d5

02 Jul, 2009 13 commits

Remove logs from empty handlers. Packet handling log is enough to know the packet was recevied. · 26f0f7e4
Vincent Pelletier authored Jul 02, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@760 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
26f0f7e4

Document a bit a sleep in the code. · b31bb9b1

Vincent Pelletier authored Jul 02, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@759 71dcc9de-d417-0410-9af5-da40c76e7ee4

b31bb9b1

"time" is not imported. Only "sleep" is. · 14a5bca2

Vincent Pelletier authored Jul 02, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@758 71dcc9de-d417-0410-9af5-da40c76e7ee4

14a5bca2

Prepare notifyDeadStorage to be callable from outside app. · fcecacd2
Vincent Pelletier authored Jul 02, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@757 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
fcecacd2

Do not call "ask" on a connection we just closed. · bb077977

Vincent Pelletier authored Jul 02, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@756 71dcc9de-d417-0410-9af5-da40c76e7ee4

bb077977

Fix decorator definition, it was not returning the wrapper. · 2ae0285c
Vincent Pelletier authored Jul 02, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@755 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
2ae0285c

Make ask, notify and answer raise ConnectorConnectionClosedException when... · d8805792

Vincent Pelletier authored Jul 02, 2009

Make ask, notify and answer raise ConnectorConnectionClosedException when called on a closed connection.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@754 71dcc9de-d417-0410-9af5-da40c76e7ee4

d8805792

Move specifics actions in each sub-handler. Remove a intermediate handler no · 3304a165

Grégory Wisniewski authored Jul 02, 2009

more usefull. Storage clear its partition table before asking it, this prevent
duplicate entries but should not be required.

git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@753 71dcc9de-d417-0410-9af5-da40c76e7ee4

3304a165

Split storage handlers. As for the primary master, all incoming connections are · ecd05c50

Grégory Wisniewski authored Jul 02, 2009

handled by the identification handler which apply the right handler depending on
the peer node type. Client and storage incoming connections are refused until
the storage reach the operation state, but the listening port is open to ensure
it's available, tryAgain errors are sent to wrong nodes.
Remove decorators because connection type is implied by handler type.

git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@752 71dcc9de-d417-0410-9af5-da40c76e7ee4

ecd05c50

Remove unused parameter. · 733e7e90

Vincent Pelletier authored Jul 02, 2009

Update callers.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@751 71dcc9de-d417-0410-9af5-da40c76e7ee4

733e7e90

Factorise master disconnection code. · afbd38a2

Vincent Pelletier authored Jul 02, 2009

Only close master_conn is it is set.
Add an assertion before closing to verify that if there is any master connection closed after primary master is set is the primary master connection itself.

git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@750 71dcc9de-d417-0410-9af5-da40c76e7ee4

afbd38a2

Remove this decorator because we don't accept incoming (non-client) connections · 86fd4cc7
Grégory Wisniewski authored Jul 02, 2009
```
during bootstrap stage.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@749 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
86fd4cc7
Add a log method on the node manager to help debugging. · cbde95b6
Grégory Wisniewski authored Jul 02, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@748 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
cbde95b6

01 Jul, 2009 9 commits

Don't restart a complete connection to primary master when... · 1a330a1d

Vincent Pelletier authored Jul 01, 2009

Don't restart a complete connection to primary master when requestNodeIdentification fails (for example if master is not ready).


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@747 71dcc9de-d417-0410-9af5-da40c76e7ee4

1a330a1d

Don't disconnect from master when it responds NotReady. · 5f6ca700
Vincent Pelletier authored Jul 01, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@746 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
5f6ca700
Move "connected to a primary master node" log from handler to app for consistency. · baf58076
Vincent Pelletier authored Jul 01, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@745 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
baf58076
Explicitely avoid loop exit condition when connecting to a server found by answerPrimaryMaster. · cea93513
Vincent Pelletier authored Jul 01, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@744 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
cea93513
Connection can be closed before we had the time to create a node from peer. · d3a96466
Vincent Pelletier authored Jul 01, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@743 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
d3a96466

Exit election loop when we know we are not the primary. · b43bf3b9

Vincent Pelletier authored Jul 01, 2009

Expect AcceptnodeIdentification message in secondary handler connected to primary master. It will be received just once (upon election state exit).


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@742 71dcc9de-d417-0410-9af5-da40c76e7ee4

b43bf3b9

Replace a bare "pass" with a warning log, as this case should never happen (to... · 18e4cdc5

Vincent Pelletier authored Jul 01, 2009

Replace a bare "pass" with a warning log, as this case should never happen (to be upgraded to a raise someday).


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@741 71dcc9de-d417-0410-9af5-da40c76e7ee4

18e4cdc5

Remove log line prefixes, as they are not in sync with the method name containing them. · bdf21345
Vincent Pelletier authored Jul 01, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@740 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
bdf21345
Add logs for each kind of connection closure caused by remote peer. · 94350c6f
Vincent Pelletier authored Jul 01, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@739 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
94350c6f