The connection may have been already added to writable events in poll, it
usefull to add it here only if the buffer was initialy empty.

git-svn-id: https://svn.erp5.org/repos/neo/trunk@1704 71dcc9de-d417-0410-9af5-da40c76e7ee4

At connection level, when packet parsing fails there is no packet instance
(in except block). As there is no meaning to log a packet when it is
malformed, remove this parameter from _packetMalformed().

git-svn-id: https://svn.erp5.org/repos/neo/trunk@1703 71dcc9de-d417-0410-9af5-da40c76e7ee4

git-svn-id: https://svn.erp5.org/repos/neo/trunk@1702 71dcc9de-d417-0410-9af5-da40c76e7ee4

git-svn-id: https://svn.erp5.org/repos/neo/trunk@1701 71dcc9de-d417-0410-9af5-da40c76e7ee4

This exception is used only during packet decoding.

git-svn-id: https://svn.erp5.org/repos/neo/trunk@1700 71dcc9de-d417-0410-9af5-da40c76e7ee4

Fix related tests.

git-svn-id: https://svn.erp5.org/repos/neo/trunk@1699 71dcc9de-d417-0410-9af5-da40c76e7ee4

git-svn-id: https://svn.erp5.org/repos/neo/trunk@1698 71dcc9de-d417-0410-9af5-da40c76e7ee4

In writable(), the _send() call could have closed the connection so don't
close it again if aborted or don't disable write events polling has this is
already done.

git-svn-id: https://svn.erp5.org/repos/neo/trunk@1697 71dcc9de-d417-0410-9af5-da40c76e7ee4

git-svn-id: https://svn.erp5.org/repos/neo/trunk@1696 71dcc9de-d417-0410-9af5-da40c76e7ee4

git-svn-id: https://svn.erp5.org/repos/neo/trunk@1695 71dcc9de-d417-0410-9af5-da40c76e7ee4

Remove hanlder methods for that packet in order to reveal if it happens in
reality, so ti could be fixed.

git-svn-id: https://svn.erp5.org/repos/neo/trunk@1694 71dcc9de-d417-0410-9af5-da40c76e7ee4

uuid variable is used both to contain peer uuid and one of the uuids sent
in message payload.

git-svn-id: https://svn.erp5.org/repos/neo/trunk@1693 71dcc9de-d417-0410-9af5-da40c76e7ee4

The implementation lacks some checks around the handling of
setClusterState, so add a TODO about this so we can get rid of former
XXX comment.

git-svn-id: https://svn.erp5.org/repos/neo/trunk@1692 71dcc9de-d417-0410-9af5-da40c76e7ee4

git-svn-id: https://svn.erp5.org/repos/neo/trunk@1691 71dcc9de-d417-0410-9af5-da40c76e7ee4

This call, whose return value is ignore, is just here to establish the
connection with master if it was cut.

git-svn-id: https://svn.erp5.org/repos/neo/trunk@1690 71dcc9de-d417-0410-9af5-da40c76e7ee4

Makes it thread-safe (with detailed explanation on for each method).
Makes it more efficient for unregister and registered uses.

git-svn-id: https://svn.erp5.org/repos/neo/trunk@1689 71dcc9de-d417-0410-9af5-da40c76e7ee4

git-svn-id: https://svn.erp5.org/repos/neo/trunk@1688 71dcc9de-d417-0410-9af5-da40c76e7ee4

Also, make logging done when catching OperationFailure exception consistent
with logging done when catching PrimaryFailure exception.

git-svn-id: https://svn.erp5.org/repos/neo/trunk@1687 71dcc9de-d417-0410-9af5-da40c76e7ee4

This does not change code flow:
- self.master_node is None when entering the loop for the first time
- there is no way to restart the loop other than a PrimaryFailure exception

git-svn-id: https://svn.erp5.org/repos/neo/trunk@1686 71dcc9de-d417-0410-9af5-da40c76e7ee4

This is identical to what is done in master/app.py:run.

git-svn-id: https://svn.erp5.org/repos/neo/trunk@1685 71dcc9de-d417-0410-9af5-da40c76e7ee4

This reduces the cost of invoking log method when the log line is not to
be emitted.
Also, don't put a space before a colon.

git-svn-id: https://svn.erp5.org/repos/neo/trunk@1684 71dcc9de-d417-0410-9af5-da40c76e7ee4

git-svn-id: https://svn.erp5.org/repos/neo/trunk@1683 71dcc9de-d417-0410-9af5-da40c76e7ee4

git-svn-id: https://svn.erp5.org/repos/neo/trunk@1682 71dcc9de-d417-0410-9af5-da40c76e7ee4

git-svn-id: https://svn.erp5.org/repos/neo/trunk@1681 71dcc9de-d417-0410-9af5-da40c76e7ee4

git-svn-id: https://svn.erp5.org/repos/neo/trunk@1680 71dcc9de-d417-0410-9af5-da40c76e7ee4

This bug was introduced in r928 and causes caches invalidations to be
effectively no-ops.

git-svn-id: https://svn.erp5.org/repos/neo/trunk@1679 71dcc9de-d417-0410-9af5-da40c76e7ee4

git-svn-id: https://svn.erp5.org/repos/neo/trunk@1678 71dcc9de-d417-0410-9af5-da40c76e7ee4

Ask/Answer packets are linked together in both direction.
The response flag is automaticaly assigned on the answer packet.
The special 'Error' packet can be used as an expected answer for any
non-ask packet.

git-svn-id: https://svn.erp5.org/repos/neo/trunk@1677 71dcc9de-d417-0410-9af5-da40c76e7ee4

A disconnection case was calling the handler method before the close(), fix
it and factorise connection closure.

git-svn-id: https://svn.erp5.org/repos/neo/trunk@1676 71dcc9de-d417-0410-9af5-da40c76e7ee4

The NotifyNodeInformation packet was not always sent before connection
closure, call abort() to ensure the write buffer is flushed before closure
so the peer can understand that it is not a primary failure.

git-svn-id: https://svn.erp5.org/repos/neo/trunk@1675 71dcc9de-d417-0410-9af5-da40c76e7ee4

Aborted connections are supposed to be closed but remains until the write
buffer is sent. Those connections must not be used for common operation
(broacast node information...).

git-svn-id: https://svn.erp5.org/repos/neo/trunk@1674 71dcc9de-d417-0410-9af5-da40c76e7ee4

Allow override the defaults to run unit, functional or both test suites.

git-svn-id: https://svn.erp5.org/repos/neo/trunk@1673 71dcc9de-d417-0410-9af5-da40c76e7ee4

git-svn-id: https://svn.erp5.org/repos/neo/trunk@1672 71dcc9de-d417-0410-9af5-da40c76e7ee4

git-svn-id: https://svn.erp5.org/repos/neo/trunk@1671 71dcc9de-d417-0410-9af5-da40c76e7ee4

git-svn-id: https://svn.erp5.org/repos/neo/trunk@1670 71dcc9de-d417-0410-9af5-da40c76e7ee4

Add a related test case.

git-svn-id: https://svn.erp5.org/repos/neo/trunk@1669 71dcc9de-d417-0410-9af5-da40c76e7ee4

git-svn-id: https://svn.erp5.org/repos/neo/trunk@1668 71dcc9de-d417-0410-9af5-da40c76e7ee4

Keep it enabled by default so tests run with it.

git-svn-id: https://svn.erp5.org/repos/neo/trunk@1667 71dcc9de-d417-0410-9af5-da40c76e7ee4

This happens from time to time in tests, most probably during shutdown as
it doesn't make tests fail. This will help tracking this bug down.

git-svn-id: https://svn.erp5.org/repos/neo/trunk@1666 71dcc9de-d417-0410-9af5-da40c76e7ee4

This allows automating tasks right before test fails (for example, dumping
database state) for later inspection.

git-svn-id: https://svn.erp5.org/repos/neo/trunk@1665 71dcc9de-d417-0410-9af5-da40c76e7ee4