W3Validator seems obsolete now since it does not validate HTML5. nu became the default validator in 417ff1ae.

/reviewed-on nexedi/erp5!786

Add some tests and fix bugs:
* https://nexedi.erp5.net/bug_module/20170426-A3962E
* another bug that columns names were not escaped ( in a project we have a custom table with a column named `use` and this breaks `upgradeSchema`  )

/reviewed-on nexedi/erp5!854

Since 8a6c4394 Item_getTrackingList sets
parent and id on brain instead of url.

testItem now passes: https://nexedijs.erp5.net/#/test_result_module/20190625-614B59A1

/reviewed-on nexedi/erp5!898

This first work on WSGI is only to stop using ZServer (Medusa),
which is a required step before moving to Zope 4. This means that
Zope should behave almost exactly the same way as before, notably:

- We don't take advantage yet of what WSGI offers, like IPv6.
- There's extra code to handle errors the same way as before
  (this is something we'll have to change for Zope 4).

The most significant change in behaviour is that the chosen WSGI server
(waitress) does some of the HTTP work in worker threads (Medusa does it
entirely in the IO thread), and the biggest consequence concerns the
deadlock debugger that is now run from the worker thread:
- it does not work if all threads are blocked
- doing better would require to patch waitress in a quite ugly way

About TimerService, we simplify things by removing the egg.
In zope.conf, it's possible to import from the product.

/reviewed-on nexedi/erp5!883

At the same time, timerserver is no longer distributed as an egg.

zope.globalrequest is a new dependency of Zope 4
and it is already used by the backported WSGIPublisher.

Parts of ZPublisher.utils are also backported.

This is a preliminary commit that only adds a verbatim copy of WSGIPublisher.py

Clinking on the rows of item tracking view was not working in renderjs ui.

/reviewed-on nexedi/erp5!894

Since BankAccount_view already has a my_comment field

Example for erp5_web_renderjs_ui_test:testFunctionalRJSRelationField, which
was failing randomly (fixed in ca229c3e):

======================================================================
FAIL: testFunctionalTestRunner (erp5.component.test.erp5_version.testFunctionalRJSRelationField.TestRenderJSUIRelationField)
----------------------------------------------------------------------
Traceback (most recent call last):
  File ".../product/ERP5Type/tests/ERP5TypeFunctionalTestCase.py", line 372, in testFunctionalTestRunner
    self.fail('\n'.join(error))
AssertionError: These messages are pending: [('/erp5_portal_faeed2c6ad773e8de11c3b643708ad55/portal_catalog', 'unindexObject', -1, 0), ('/erp5_portal_faeed2c6ad773e8de11c3b643708ad55/foo_module', 'immediateReindexObject', -1, 0), ('/erp5_portal_faeed2c6ad773e8de11c3b643708ad55/bar_module', 'immediateReindexObject', -1, 0), ('/erp5_portal_faeed2c6ad773e8de11c3b643708ad55/foo_bar_module', 'immediateReindexObject', -1, 0), ('/erp5_portal_faeed2c6ad773e8de11c3b643708ad55/portal_preferences/erp5_ui_test_preference', 'immediateReindexObject', -1, 0), ('/erp5_portal_faeed2c6ad773e8de11c3b643708ad55/foo_module/2', 'immediateReindexObject', -1, 0), ('/erp5_portal_faeed2c6ad773e8de11c3b643708ad55/foo_module/2', 'immediateReindexObject', -1, 0), ('/erp5_portal_faeed2c6ad773e8de11c3b643708ad55/foo_module/3', 'immediateReindexObject', -1, 0), ('/erp5_portal_faeed2c6ad773e8de11c3b643708ad55/foo_module', 'immediateReindexObject', -2, 1), ('/erp5_portal_faeed2c6ad773e8de11c3b643708ad55/bar_module', 'immediateReindexObject', -2, 1), ('/erp5_portal_faeed2c6ad773e8de11c3b643708ad55/foo_bar_module', 'immediateReindexObject', -2, 1), ('/erp5_portal_faeed2c6ad773e8de11c3b643708ad55/portal_preferences/erp5_ui_test_preference', 'immediateReindexObject', -2, 1)]
Last error message:
RuntimeError
tic is looping forever.
Traceback (innermost last):
  Module ZPublisher.Publish, line 138, in publish
    request, bind=1)
  Module ZPublisher.mapply, line 77, in mapply
    if debug is not None: return debug(object,args,context)
  Module ZPublisher.Publish, line 48, in call_object
    result=apply(object,args) # Type s<cr> to step into published object.
  Module Products.ERP5Type.patches.ExternalMethod, line 113, in __call__
    return _f[0](self.aq_parent, *args, **kw)
  Module erp5.component.extension.erp5_version.ERP5Zuite, line 21, in waitForActivities
    raise RuntimeError('tic is looping forever.')
RuntimeError: tic is looping forever.

testAccessUnauthorizedRelationValue
testBreadcrumbCanNotAccessRelationSearchPage
testMultiRelationDefaultSortAndParameterList
testMultiRelationFieldEmptySearchWithListbox
testMultiRelationFieldHomonyms
testMultiRelationFieldSearchWithListbox
testMultiRelationFieldSearchWithProxyListbox
testMultiRelationFieldUnknownIcon
testMultiRelationFieldWithNonSavedPageContent
testProxyListBox
testRelationDefaultSortAndParameterList
testRelationFieldEmptySearchWithListbox
testRelationFieldRefresh
testRelationFieldSearchWithListbox
testRelationFieldWithNonSavedPageContent
testSimpleMultiRelationField

----------------------------------------------------------------------
Ran 1 test in 199.267s

Ensure permission removal is done after the indexation

Stop using the update action as the default action.

[erp5_base]
Allow Manager to solve the divergency
Pass the transition ID as the other workflow actions

[erp5_simulation]
Prevent duplicated keep_items

Fix request value modifications

Do not mark fields as required
The RJS field marks it as required, and user can't submit anymore.
Instead, use an external validator to only require the field when the user submit

clicked on the update button

Do not crash if the form can not be fetched.

Formbox context can be a listbox cell.

These are very outdated stuff (pre-Business Templates), they do not scale
and (except ImportExportSkins) try to write to a paths which should not
exist.

Especially in chrome (75), it's very hard to see selected text in erp5
xhtml style interface, especially in listboxs.
Chrome adds a background color to selected text, but this background is
almost same color as ERP5 background.

This uses https://developer.mozilla.org/en-US/docs/Web/CSS/::selection
to make it visually clear what is selected.

/reviewed-on !889

https://microsoft.github.io/monaco-editor/ as an ERP5 source code editor.


/reviewed-on nexedi/erp5!687

This is needed to support datawarehouse on another database.

Simplifies activity spawning when dependencies are conditionally set:
  activate(
    after_tag=some_value if some_condition else None,
  )
instead of having to do a ** dance.
All columns involved in dependency checking are declared NOT NULL, so providing
"None" and expecting a dependency to happen was already not working.
This change pushes this one step further by allowing activity
auto-validation also happen on these activities.
Also, simplify getOrderValidationText: avoid iterating on keys and then
retrieving values, use a list-comprehension, simplify condition.
Add a test for after_tag, also covering activity auto-validation.

Unit Tests: login*() with a non-ERP5TypeTestCase user was adding ERP5TypeTestCase user anyway and failure was silently ignored.

checkValidity calls getContent, which uses the same mutex

Improve the query speed by using the default listbox sort.

ERP5TypeTestCase: replace ZPublisher.Test.publish_module with ZPublisher.Publish.publish_module_standard