Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
W
wendelin.core
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Joshua
wendelin.core
Commits
24dc5d96
Commit
24dc5d96
authored
Feb 19, 2020
by
Kirill Smelkov
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
.
parent
f077ed67
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
3 additions
and
3 deletions
+3
-3
wcfs/client/wcfs.cpp
wcfs/client/wcfs.cpp
+3
-3
No files found.
wcfs/client/wcfs.cpp
View file @
24dc5d96
...
...
@@ -255,15 +255,15 @@ error _Conn::__pin1(PinReq *req) {
FileH
f
;
bool
ok
;
wconn
.
_atMu
.
RLock
();
// XXX deadlock wrt Conn.
open, Conn.
resync ?
wconn
.
_atMu
.
RLock
();
// XXX deadlock wrt Conn.resync ?
defer
([
&
]()
{
wconn
.
_atMu
.
RUnlock
();
});
// XXX deadlock wrt Conn.
open which locks wconn.filehmu and starts initial "watch"
// XXX deadlock wrt Conn.
resync which locks wconn.mu and does "watch" ?
wconn
.
_mu
.
lock
();
// XXX +incref f, so that simultaneous close does not remove f from wconn.filehTab ?
// XXX or just make FileH.close lock f too to synchroniz
w
with pinner?
// XXX or just make FileH.close lock f too to synchroniz
e
with pinner?
tie
(
f
,
ok
)
=
wconn
.
_filehTab
.
get_
(
req
->
foid
);
if
(
!
ok
)
{
wconn
.
_mu
.
unlock
();
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment