.

wcfs/client/wcfs.cpp

@@ -264,6 +264,15 @@ error _Conn::__pin1(PinReq *req) {
         error err;
         if (mmap->vma != nil) {
             mmap->_assertVMAOk();
+            // XXX recheck wrt Mapping.unmap: there it locks:
+            // 1. virt_lock
+            // 2. f.mu
+            //
+            // -> if here we do
+            // 1. f.mu
+            // 2. virt_lock
+            //
+            // -> deadlock
             virt_lock();
             BigFileH *virt_fileh = mmap->vma->fileh;
             TODO (mmap->fileh->blksize != virt_fileh->ramh->ram->pagesize);
@@ -504,9 +513,8 @@ error _Mapping::unmap() {
     mmap->mem_stop  = nil;
     // XXX clear other fields?
 
+    // XXX do it first? (to avoid pinner going through f.mmaps and hitting unmapped memory)
     //f->_mmaps.remove(mmap);
-
-    // FIXME keep mmaps sorted
     f->_mmaps.erase(
         std::remove(f->_mmaps.begin(), f->_mmaps.end(), mmap),
         f->_mmaps.end());