issues_spec.rb 6.71 KB
Newer Older
gitlabhq's avatar
gitlabhq committed
1 2 3
require 'spec_helper'

describe "Issues" do
4
  let(:project) { create(:project) }
gitlabhq's avatar
gitlabhq committed
5

Nihad Abbasov's avatar
Nihad Abbasov committed
6
  before do
gitlabhq's avatar
gitlabhq committed
7
    login_as :user
Riyad Preukschas's avatar
Riyad Preukschas committed
8
    user2 = create(:user)
gitlabhq's avatar
fixes  
gitlabhq committed
9

10
    project.team << [[@user, user2], :developer]
gitlabhq's avatar
gitlabhq committed
11 12
  end

13
  describe "Edit issue" do
Riyad Preukschas's avatar
Riyad Preukschas committed
14 15 16 17 18 19 20
    let!(:issue) do
      create(:issue,
             author: @user,
             assignee: @user,
             project: project)
    end

Nihad Abbasov's avatar
Nihad Abbasov committed
21
    before do
gitlabhq's avatar
gitlabhq committed
22 23 24 25
      visit project_issues_path(project)
      click_link "Edit"
    end

Nihad Abbasov's avatar
Nihad Abbasov committed
26
    it "should open new issue popup" do
27
      page.should have_content("Issue ##{issue.iid}")
gitlabhq's avatar
gitlabhq committed
28 29
    end

Nihad Abbasov's avatar
Nihad Abbasov committed
30
    describe "fill in" do
gitlabhq's avatar
gitlabhq committed
31
      before do
32 33
        fill_in "issue_title", with: "bug 345"
        fill_in "issue_description", with: "bug description"
gitlabhq's avatar
gitlabhq committed
34 35
      end

36
      it { expect { click_button "Save changes" }.to_not change {Issue.count} }
gitlabhq's avatar
gitlabhq committed
37

Nihad Abbasov's avatar
Nihad Abbasov committed
38
      it "should update issue fields" do
39
        click_button "Save changes"
gitlabhq's avatar
gitlabhq committed
40 41 42 43 44 45 46

        page.should have_content @user.name
        page.should have_content "bug 345"
        page.should have_content project.name
      end
    end
  end
Adam Leonard's avatar
Adam Leonard committed
47

48 49 50
  describe "Filter issue" do
    before do
      ['foobar', 'barbaz', 'gitlab'].each do |title|
Riyad Preukschas's avatar
Riyad Preukschas committed
51 52 53 54 55
        create(:issue,
               author: @user,
               assignee: @user,
               project: project,
               title: title)
56 57
      end

58 59 60 61
      @issue = Issue.first # with title 'foobar'
      @issue.milestone = create(:milestone, project: project)
      @issue.assignee = nil
      @issue.save
62 63
    end

64
    let(:issue) { @issue }
Riyad Preukschas's avatar
Riyad Preukschas committed
65

66 67 68 69 70 71 72 73 74
    it "should allow filtering by issues with no specified milestone" do
      visit project_issues_path(project, milestone_id: '0')

      page.should_not have_content 'foobar'
      page.should have_content 'barbaz'
      page.should have_content 'gitlab'
    end

    it "should allow filtering by a specified milestone" do
Riyad Preukschas's avatar
Riyad Preukschas committed
75
      visit project_issues_path(project, milestone_id: issue.milestone.id)
76 77 78 79 80

      page.should have_content 'foobar'
      page.should_not have_content 'barbaz'
      page.should_not have_content 'gitlab'
    end
81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96

    it "should allow filtering by issues with no specified assignee" do
      visit project_issues_path(project, assignee_id: '0')

      page.should have_content 'foobar'
      page.should_not have_content 'barbaz'
      page.should_not have_content 'gitlab'
    end

    it "should allow filtering by a specified assignee" do
      visit project_issues_path(project, assignee_id: @user.id)

      page.should_not have_content 'foobar'
      page.should have_content 'barbaz'
      page.should have_content 'gitlab'
    end
97
  end
98 99 100 101 102 103

  describe 'filter issue' do
    titles = ['foo','bar','baz']
    titles.each_with_index do |title, index|
      let!(title.to_sym) { create(:issue, title: title, project: project, created_at: Time.now - (index * 60)) }
    end
104 105
    let(:newer_due_milestone) { create(:milestone, due_date: '2013-12-11') }
    let(:later_due_milestone) { create(:milestone, due_date: '2013-12-12') }
106 107 108

    it 'sorts by newest' do
      visit project_issues_path(project, sort: 'newest')
109

110 111
      first_issue.should include("foo")
      last_issue.should include("baz")
112 113 114 115 116
    end

    it 'sorts by oldest' do
      visit project_issues_path(project, sort: 'oldest')

117 118
      first_issue.should include("baz")
      last_issue.should include("foo")
119 120 121 122 123 124 125
    end

    it 'sorts by most recently updated' do
      baz.updated_at = Time.now + 100
      baz.save
      visit project_issues_path(project, sort: 'recently_updated')

126
      first_issue.should include("baz")
127 128 129 130 131 132 133
    end

    it 'sorts by least recently updated' do
      baz.updated_at = Time.now - 100
      baz.save
      visit project_issues_path(project, sort: 'last_updated')

134
      first_issue.should include("baz")
135 136 137
    end

    describe 'sorting by milestone' do
138
      before :each do
139 140 141 142 143 144 145 146 147
        foo.milestone = newer_due_milestone
        foo.save
        bar.milestone = later_due_milestone
        bar.save
      end

      it 'sorts by recently due milestone' do
        visit project_issues_path(project, sort: 'milestone_due_soon')

148
        first_issue.should include("foo")
149 150 151 152 153
      end

      it 'sorts by least recently due milestone' do
        visit project_issues_path(project, sort: 'milestone_due_later')

154
        first_issue.should include("bar")
155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170
      end
    end

    describe 'combine filter and sort' do
      let(:user2) { create(:user) }

      before :each do
        foo.assignee = user2
        foo.save
        bar.assignee = user2
        bar.save
      end

      it 'sorts with a filter applied' do
        visit project_issues_path(project, sort: 'oldest', assignee_id: user2.id)

171 172
        first_issue.should include("bar")
        last_issue.should include("foo")
173 174 175 176
        page.should_not have_content 'baz'
      end
    end
  end
177

178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194
  describe 'update assignee from issue#show' do
    let(:issue) { create(:issue, project: project, author: @user) }

    context 'by autorized user' do

      it 'with dropdown menu' do
        visit project_issue_path(project, issue)

        find('.edit-issue.inline-update').select(project.team.members.first.name, from: 'issue_assignee_id')
        click_button 'Update Issue'

        page.should have_content "currently assigned to"
        page.has_select?('issue_assignee_id', :selected => project.team.members.first.name)
      end
    end

    context 'by unauthorized user' do
Dmitriy Zaporozhets's avatar
Dmitriy Zaporozhets committed
195

196
      let(:guest) { create(:user) }
Dmitriy Zaporozhets's avatar
Dmitriy Zaporozhets committed
197

198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227
      before :each do
        project.team << [[guest], :guest]
        issue.assignee = @user
        issue.save
      end

      it 'shows assignee text' do
        logout
        login_with guest

        visit project_issue_path(project, issue)
        page.should have_content "currently assigned to #{issue.assignee.name}"

      end
    end

  end

  describe 'update milestone from issue#show' do
    let!(:issue) { create(:issue, project: project, author: @user) }
    let!(:milestone) { create(:milestone, project: project) }

    context 'by authorized user' do

      it 'with dropdown menu' do
        visit project_issue_path(project, issue)

        find('.edit-issue.inline-update').select(milestone.title, from: 'issue_milestone_id')
        click_button 'Update Issue'

Dmitriy Zaporozhets's avatar
Dmitriy Zaporozhets committed
228
        page.should have_content "Attached to milestone"
229 230 231 232 233
        page.has_select?('issue_assignee_id', :selected => milestone.title)
      end
    end

    context 'by unauthorized user' do
Dmitriy Zaporozhets's avatar
Dmitriy Zaporozhets committed
234

235
      let(:guest) { create(:user) }
Dmitriy Zaporozhets's avatar
Dmitriy Zaporozhets committed
236

237 238 239 240 241 242 243 244 245 246 247 248
      before :each do
        project.team << [[guest], :guest]
        issue.milestone = milestone
        issue.save
      end

      it 'shows milestone text' do
        logout
        login_with guest

        visit project_issue_path(project, issue)

Dmitriy Zaporozhets's avatar
Dmitriy Zaporozhets committed
249
        page.should have_content "Attached to milestone #{milestone.title}"
250 251 252 253
      end
    end
  end

254 255 256 257 258 259 260
  def first_issue
    all("ul.issues-list li").first.text
  end

  def last_issue
    all("ul.issues-list li").last.text
  end
gitlabhq's avatar
gitlabhq committed
261
end