• Tim Peters's avatar
    Collector #1307: fsrecover.py broken on HEAD. · 7bb97358
    Tim Peters authored
    fsrecover.py:  the call to restore() was still using .serial, which no
    longer exists.  Changed to use .tid.
    
    testRecover.py:  the tests here passed despite that fsrecover wasn't
    working at all.  Changed RecoverTest.recover() to eliminate its unused
    arguments, and to return all the output fsrecover.recover() produces (the
    output was being thrown away, unlooked at).  Added new testNoDamage(),
    which feeds recovery a healthy .fs, and then looks at the output of
    recovery, to verify that no errors were reported and no bytes were
    removed by recovery.  Changed all the other tests to stop passing unused
    arguments to RecoverTest.recover(), and to verify that error output was
    produced by recovery.
    
    XXX I'm not sure that every call to RecoverTest.recover() will actually
    XXX produce an error in fsrecover.recover(), so we may get some spurious
    XXX test failures here.  I'll keep my open for those.  (The kinds of
    XXX damage tested are randomized, so one run doesn't prove anything.)
    7bb97358
testRecover.py 5.38 KB