ClientThread(): Some of the packing tests still fail in rare & strange
ways, but unittest never notices this because the tests always fail in a thread unittest doesn't know anything about. Changed ClientThread to derive from the MTStorage tests' TestThread, which arranges to re-raise a thread-death exception in the main thread. Tested "by hand", via temporarily forcing fatal thread exceptions in all the Pack[Now]WhileWriting tests; unittest did notice those now. So, when this happens again in real life, we'll no longer be fooled by test runner reports claiming that everything passed, and then frustrated by not even being able to tell which test failed (you can't tell from the isolated thread traceback(s) wading in the sea of testrunner dot output).
Showing
Please register or sign in to comment