Commit e362c591 authored by Jim Fulton's avatar Jim Fulton

Fixed a threading bug.

parent 814ab53d
...@@ -1346,7 +1346,20 @@ class ClientStub: ...@@ -1346,7 +1346,20 @@ class ClientStub:
self.rpc.callAsync('endVerify') self.rpc.callAsync('endVerify')
def invalidateTransaction(self, tid, args): def invalidateTransaction(self, tid, args):
self.rpc.callAsync('invalidateTransaction', tid, args) # Note that this method is *always* called from a different
# thread than self.rpc's async thread. It is the only method
# for which this is true and requires special consideration!
# callAsyncNoSend is important here because:
# - callAsyncNoPoll isn't appropriate because
# the network thread may not wake up for a long time,
# delaying invalidations for too long. (This is demonstrateed
# by a test failure.)
# - callAsync isn't appropriate because (on the server) it tries
# to write to the socket. If self.rpc's network thread also
# tries to write at the ame time, we can run into problems
# because handle_write isn't thread safe.
self.rpc.callAsyncNoSend('invalidateTransaction', tid, args)
def serialnos(self, arg): def serialnos(self, arg):
self.rpc.callAsyncNoPoll('serialnos', arg) self.rpc.callAsyncNoPoll('serialnos', arg)
......
...@@ -535,6 +535,15 @@ class Connection(smac.SizedMessageAsyncConnection, object): ...@@ -535,6 +535,15 @@ class Connection(smac.SizedMessageAsyncConnection, object):
raise DisconnectedError() raise DisconnectedError()
self.send_call(method, args, 1) self.send_call(method, args, 1)
def callAsyncNoSend(self, method, *args):
# Like CallAsync but doesn't poll. This exists so that we can
# send invalidations atomically to all clients without
# allowing any client to sneak in a load request.
if self.closed:
raise DisconnectedError()
self.send_call(method, args, 1)
self.call_from_thread()
def callAsyncIterator(self, iterator): def callAsyncIterator(self, iterator):
"""Queue a sequence of calls using an iterator """Queue a sequence of calls using an iterator
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment