1. 12 Jul, 2005 2 commits
    • Tim Peters's avatar
      Merge rev 33285 from 3.4 branch. · 6ad07564
      Tim Peters authored
      Convert internal uses of subtxns to use savepoints instead.
      
      I suspect BTrees/convert.py should be removed instead.
      6ad07564
    • Tim Peters's avatar
      Merge rev 33276 from 3.4 branch. · 22d59055
      Tim Peters authored
      Revert extra copying in Connection._rollback().
      
      Since TmpStore.reset() had to change too to copy the index anyway,
      it no longer hurts that _rollback() clears the index (as a side
      effect of self._cache.invalidate(src.index)).
      22d59055
  2. 11 Jul, 2005 2 commits
    • Tim Peters's avatar
      Merge rev 33273 from 3.4 branch. · ce0290a6
      Tim Peters authored
      Merge tim-savepoint branch.
      
      Allow rollback to a given savepoint multiple times.
      
      transaction/_transaction.py
          _remove_and_invalidate_after():  Don't remove the
          argument savepoint from the savepoint stack anymore.
      
          abort():  abort(True) relied on the subtxn savepoint
          being invalidated as a side effect of rolling back
          to it.  Invalidate it explicitly now.
      
          Savepoint.rollback():  Don't invalidate self.
      
      ZODB/Connection.py
          Connection._rollback():  Pass a temp container to
          _cache.invalidate(), because that method clears the
          container as a side effect.  Clearing the index
          in a savepoint was a disaster if the savepoint was
          used again.
      
          TmpStore.reset():  Make a copy of the argument index.
          An alternative would be to make all callers make
          copies, but the only caller now thinks of its `state`
          argument as being opaque.
      
      transaction/savepoint.txt
      ZODB/tests/{testSubTransaction.py, testConnectionSavepoint.txt}
          Test the new semantics, and beef up the tests.
      
      transaction/tests/savepointsample.py
          _rollback_savepoint():  Needed to copy the data.
      ce0290a6
    • Tim Peters's avatar
      Merge rev 33265 from 3.4 branch. · 28dd6d89
      Tim Peters authored
      English repairs.
      28dd6d89
  3. 08 Jul, 2005 1 commit
  4. 05 Jul, 2005 3 commits
    • Tim Peters's avatar
      Merge rev 31016 from 3.4 branch. · 3b8d1eb9
      Tim Peters authored
      Simplify.
      
      Primarily, _tindex should have been a dict all along, pack()
      worked too hard at the end, and loadEx() is a minor variant
      of load().
      3b8d1eb9
    • Tim Peters's avatar
      Merge rev 31012 from 3.4 branch. · a58e7181
      Tim Peters authored
      load() and loadEx():  eliminate gratuitous differences.
      
      Ideally, load() should call loadEx() instead, but we really
      don't want "an extra" Python-level call here (heavily used).
      
      loadEx():  deleted pointless call of self._read_txn_header().
      
      ServerStub.loadEx() comments:  these were obviously wrong in
      several ways, but I don't know the full truth.  Better to
      say so up front than to leave them clearly wrong, though.
      a58e7181
    • Tim Peters's avatar
      Merge rev 31010 from 3.4 branch. · 729faf25
      Tim Peters authored
      Collector 1831.
      
      The BTree minKey() and maxKey() methods gave a misleading message if no key
      satisfying the constraints existed in a non-empty tree.
      729faf25
  5. 02 Jul, 2005 3 commits
    • Tim Peters's avatar
      Merge rev 30988 from 3.4 branch. · 15537907
      Tim Peters authored
      Collector #1830.
      
      In some error cases when reading a FileStorage index, the
      code referenced an undefined global.
      15537907
    • Tim Peters's avatar
      Merge rev 30984 from 3.4 branch. · b1427270
      Tim Peters authored
      Get rid of all code defining or referencing t32.
      
      Such code never made sense; it was all of the form
      
          t32 = 1L << 32
          if something < 0:
              something = t32 - something
      
      which is a way to change negative integers into
      gigantic positive integers greater than 4 billion, and
      never made sense in context.  Possibly
      
              something = t32 + something
      
      was intended, but that never made sense in context either.
      
      In any case, `something` is invariably obtained from
      struct.unpack using the "H" format code, and that never
      returns a negative integer to begin with.
      b1427270
    • Tim Peters's avatar
      Merge rev 30984 from 3.4 branch. · 844a079a
      Tim Peters authored
      read_index():  Mechanical reformat for easier reading.
      844a079a
  6. 01 Jul, 2005 2 commits
  7. 29 Jun, 2005 1 commit
    • Tim Peters's avatar
      Merge rev 30944 from 3.4 branch. · 45814f90
      Tim Peters authored
      Collector 1822.
      
      Make undo{Log,Info} arguments act like Python slice indices when
      both are non-negative.  The code used to do that before ZODB 3.4a9,
      but changed to match ZODB's UML documentation.  Alas, some
      (untested) code in Zope relied on the actual behavior (see the
      collector report).  Changed code, docs, and tests to bless the
      old behavior in these cases.
      
      DemoStorage.UndoLog:  this was wrong in several ways.  I'm still
      unsure about why it skips "packed" transactions.  That doesn't seem
      right, but I don't have time to wonder about that now.
      45814f90
  8. 27 Jun, 2005 1 commit
  9. 24 Jun, 2005 1 commit
    • Tim Peters's avatar
      Merge rev 30900 from 3.4 branch. · 35136be9
      Tim Peters authored
      _triggerbase:  Make new-style class, for better debugability.
      
      Windows trigger.__init__:  Simplify more.  The trigger can connect
      after the other end has done  bind() and listen(); no need to wait
      for an accept() too, and so no need to fiddle with blocking/
      non-blocking or "expected" socket.error's either.
      35136be9
  10. 22 Jun, 2005 1 commit
    • Tim Peters's avatar
      Merge rev 30894 from 3.4 branch. · c43d7912
      Tim Peters authored
      Largely rewritten.
      
      remove_loop_callback():  There were two definitions of this function.
      Deleted one, changed the other to use enumerate().
      
      poll():  This was trying to repair a bug in Python 2.2's asyncore.poll().
      2.2 is no longer supported, so removed this poll().
      
      _start_loop(), _stop_loop():  Removed; functionality folded into
      reworked loop().
      
      loop():  The signature of asyncore.loop() changed in 2.4, but this
      still had "the old" signature.  Instead of sniffing the signature
      of the Python in use, this does a saner thing:  the original
      asyncore.loop is captured, and called from the body of this loop().
      That way, (A) we don't care what asyncore.loop's signature is; and,
      (B) we still call the original Python code, so debugging prints and
      breakpoints (etc) stuffed into Python's asyncore no longer "vanish
      by magic" when ZEO is used.
      c43d7912
  11. 21 Jun, 2005 1 commit
    • Tim Peters's avatar
      Merge rev 30877 from 3.4 branch. · f0bb9db5
      Tim Peters authored
      Massive refactoring, to move the bulk of the trigger code into
      an OS-indepedent base class.
      
      __repr__:  Use the postive_id function to embed the machine address.
      Addresses with the high bit set trigger warnings before Python 2.4,
      and come out as negative numbers in 2.4+.
      
      Windows trigger.__init__:  Don't make 50 guesses at a port number
      to use, let Windows pick an available port for us.  Also documented
      the baffling single-thread socket setup dance, which took an hour to
      reverse-engineer (in large part because it used a bare "except" w/ no
      clue as to why).
      f0bb9db5
  12. 17 Jun, 2005 2 commits
    • Jim Fulton's avatar
      Updated release numbers. · 1477c3c9
      Jim Fulton authored
      1477c3c9
    • Jim Fulton's avatar
      We check for implicitly adding objects by looking for "new" objects · 316ea575
      Jim Fulton authored
      reachable from multiple connections.  Previously, we thought that we
      could limit the time that an object was new to a single savepoint, but
      that didn't work because savepoints of different connections are too
      independent.   Now an object is considered new for the full extent of
      the transaction in which it was created.
      
      Made it possible to use connection add methods to explicitly control
      the database an object is added too.
      316ea575
  13. 16 Jun, 2005 8 commits
  14. 15 Jun, 2005 1 commit
  15. 14 Jun, 2005 1 commit
  16. 10 Jun, 2005 2 commits
  17. 09 Jun, 2005 8 commits