1. 07 Sep, 2016 1 commit
  2. 05 Sep, 2016 2 commits
  3. 18 Aug, 2016 1 commit
  4. 05 Aug, 2016 1 commit
  5. 04 Aug, 2016 1 commit
  6. 28 Jul, 2016 1 commit
  7. 27 Jul, 2016 2 commits
  8. 26 Jul, 2016 2 commits
  9. 24 Jul, 2016 5 commits
  10. 23 Jul, 2016 2 commits
  11. 21 Jul, 2016 2 commits
  12. 17 Jul, 2016 3 commits
  13. 13 Jul, 2016 2 commits
  14. 12 Jul, 2016 13 commits
    • Jim Fulton's avatar
      Fix testMinimizeTerminates · f4e9202f
      Jim Fulton authored
      This test was spewing exceptions without failing for ZODB5.
      
      The spew was an indication that something was wrong in this case. (The
      test was broken.)
      
      There had been some bug in the object cache that caused an infinite
      loop when objects woke themselves up while being reaped.  This test is
      a regression test for that bug.
      
      The test was sloppy about transaction managers.  The test class
      creates a bunch of connections using the threaded transaction manager,
      but this test used a thread to execute the critical code.  As a
      result, the synchronization methods weren't called.  This didn't
      matter much with ZODB4.  The objects were still able to load their
      state.
      
      With ZODB5, the synchronization methods are important for proper MVCC
      and because they weren't called, the objects' state couldn't be
      reloaded, with 2 effects:
      
      - Spew
      
      - The test wasn't really testing that object's that reloaded
        themselves didn't create an infinite loop.
      
      Changed the test to not use a threaded transaction manager.
      f4e9202f
    • Julien Muchembled's avatar
      fstail: print the txn offset and header size, instead of only the data offset · 3807ace8
      Julien Muchembled authored
      Before:
      
          2016-07-01 09:41:50.416574: hash=d7101c5ee7b8e412d7b6d54873204421e09b7f34
          user='' description='' length=1629 offset=58990284
      
      After:
      
          2016-07-01 09:41:50.416574: hash=d7101c5ee7b8e412d7b6d54873204421e09b7f34
          user='' description='' length=1629 offset=58990261 (+23)
      
      The structure of a FileStorage DB is such that it's easy to revert the last
      transactions, by truncating the file at the right offset. With the above
      change, `fstail` can now be used to get this offset.
      
      In the above example:
      
          truncate -s 58990261 Data.fs
      
      would delete the transaction and all those after.
      3807ace8
    • Jim Fulton's avatar
      removed out of date comment · 5fa51838
      Jim Fulton authored
      5fa51838
    • Jim Fulton's avatar
      Refactored FileStorage transactional undo · 436d6e7b
      Jim Fulton authored
      As part of a project to provide object-level commit locks for ZEO, I'm
      refactiring FileStorage to maintain transaction-specific data in
      Tranaction.data.  This involved undo.  In trying to figure this out, I
      found:
      
      - A bug in _undoDataInfo, which I verified with some tests and
      
      - _transactionalUndoRecord was maddeningly difficult to reason about
        (and thus change).
      
      I was concerned less by the bug than my inability to know whether a
      change to the code would be correct.
      
      So I refactored the code, mainly transactionalUndoRecord, to make the
      code easier to understand, fixing some logic errors (I'm pretty sure)
      along the way.  This included lots of comments. (Comments are much
      easier to compose when you're working out logic you didn't
      understand.)
      
      In addition to makeing the code cleaner, it allows undo to be handled
      in cases that weren't handled before.
      436d6e7b
    • Jim Fulton's avatar
      Merge pull request #89 from zopefoundation/undo-refactor · 75bae1a6
      Jim Fulton authored
      Refactored FileStorage transactional undo
      75bae1a6
    • Jim Fulton's avatar
      removed out of date comment · b563487e
      Jim Fulton authored
      b563487e
    • Jim Fulton's avatar
      Merge pull request #87 from NextThought/handle-serials · 686f169f
      Jim Fulton authored
      Per @jimfulton, handle_all_serials shouldn't be sniffing in ZODB5
      
      Thanks.
      686f169f
    • Jim Fulton's avatar
      Merge pull request #86 from NextThought/handle-serials4 · e080bdcc
      Jim Fulton authored
      Fix handle_all_serials for the new and old protocols.
      e080bdcc
    • Jason Madden's avatar
      Update comment. [skip ci] · c13649da
      Jason Madden authored
      c13649da
    • Jason Madden's avatar
    • Jim Fulton's avatar
      changes · d64a0cbf
      Jim Fulton authored
      d64a0cbf
    • Jim Fulton's avatar
      Refactored FileStorage transactional undo · d717a685
      Jim Fulton authored
      As part of a project to provide object-level commit locks for ZEO, I'm
      refactiring FileStorage to maintain transaction-specific data in
      Tranaction.data.  This involved undo.  In trying to figure this out, I
      found:
      
      - A bug in _undoDataInfo, which I verified with some tests and
      
      - _transactionalUndoRecord was maddeningly difficult to reason about
        (and thus change).
      
      I was concerned less by the bug than my inability to know whether a
      change to the code would be correct.
      
      So I refactored the code, mainly transactionalUndoRecord, to make the
      code easier to understand, fixing some logic errors (I'm pretty sure)
      along the way.  This included lots of comments. (Comments are much
      easier to compose when you're working out logic you didn't
      understand.)
      
      In addition to makeing the code cleaner, it allows undo to be handled
      in cases that weren't handled before.
      d717a685
    • Jim Fulton's avatar
      Long lines. Grrrr. · a6c1713d
      Jim Fulton authored
      a6c1713d
  15. 11 Jul, 2016 2 commits