Commit 384b4342 authored by Stefan H. Holek's avatar Stefan H. Holek

transaction.commit(1) is deprecated in favor of transaction.savepoint().

parent d6e7db04
Unreleased Unreleased
- transaction.commit(1) is deprecated in favor of transaction.savepoint().
- Don't break if Python distros ship without profile support (Debian, Ubuntu). - Don't break if Python distros ship without profile support (Debian, Ubuntu).
- Functional.publish() would hang if it got a request_method argument other - Functional.publish() would hang if it got a request_method argument other
than GET or HEAD while omitting the stdin argument. than GET or HEAD while omitting the stdin argument.
......
...@@ -42,7 +42,7 @@ class TestCopyPaste(ZopeTestCase.ZopeTestCase): ...@@ -42,7 +42,7 @@ class TestCopyPaste(ZopeTestCase.ZopeTestCase):
self.folder.addDTMLMethod('doc', file='foo') self.folder.addDTMLMethod('doc', file='foo')
# _p_oids are None until we commit a subtransaction # _p_oids are None until we commit a subtransaction
self.assertEqual(self.folder._p_oid, None) self.assertEqual(self.folder._p_oid, None)
transaction.commit(1) transaction.savepoint()
self.failIfEqual(self.folder._p_oid, None) self.failIfEqual(self.folder._p_oid, None)
def testCutPaste(self): def testCutPaste(self):
...@@ -93,7 +93,7 @@ class TestImportExport(ZopeTestCase.ZopeTestCase): ...@@ -93,7 +93,7 @@ class TestImportExport(ZopeTestCase.ZopeTestCase):
self.folder.addDTMLMethod('doc', file='foo') self.folder.addDTMLMethod('doc', file='foo')
# _p_oids are None until we commit a subtransaction # _p_oids are None until we commit a subtransaction
self.assertEqual(self.folder._p_oid, None) self.assertEqual(self.folder._p_oid, None)
transaction.commit(1) transaction.savepoint()
self.failIfEqual(self.folder._p_oid, None) self.failIfEqual(self.folder._p_oid, None)
def testExport(self): def testExport(self):
...@@ -315,7 +315,7 @@ class TestTransactionAbort(ZopeTestCase.ZopeTestCase): ...@@ -315,7 +315,7 @@ class TestTransactionAbort(ZopeTestCase.ZopeTestCase):
def testSubTransactionAbort(self): def testSubTransactionAbort(self):
self.folder.foo = 1 self.folder.foo = 1
self.failUnless(hasattr(self.folder, 'foo')) self.failUnless(hasattr(self.folder, 'foo'))
transaction.commit(1) transaction.savepoint()
transaction.abort() transaction.abort()
# This time the abort nukes the foo attribute... # This time the abort nukes the foo attribute...
self.failIf(hasattr(self.folder, 'foo')) self.failIf(hasattr(self.folder, 'foo'))
...@@ -330,7 +330,7 @@ class TestTransactionAbort(ZopeTestCase.ZopeTestCase): ...@@ -330,7 +330,7 @@ class TestTransactionAbort(ZopeTestCase.ZopeTestCase):
def testSubTransactionAbortPersistent(self): def testSubTransactionAbortPersistent(self):
self.folder._p_foo = 1 self.folder._p_foo = 1
self.failUnless(hasattr(self.folder, '_p_foo')) self.failUnless(hasattr(self.folder, '_p_foo'))
transaction.commit(1) transaction.savepoint()
transaction.abort() transaction.abort()
# This time the abort nukes the _p_foo attribute... # This time the abort nukes the _p_foo attribute...
self.failIf(hasattr(self.folder, '_p_foo')) self.failIf(hasattr(self.folder, '_p_foo'))
...@@ -345,7 +345,7 @@ class TestTransactionAbort(ZopeTestCase.ZopeTestCase): ...@@ -345,7 +345,7 @@ class TestTransactionAbort(ZopeTestCase.ZopeTestCase):
def testSubTransactionAbortVolatile(self): def testSubTransactionAbortVolatile(self):
self.folder._v_foo = 1 self.folder._v_foo = 1
self.failUnless(hasattr(self.folder, '_v_foo')) self.failUnless(hasattr(self.folder, '_v_foo'))
transaction.commit(1) transaction.savepoint()
transaction.abort() transaction.abort()
# This time the abort nukes the _v_foo attribute... # This time the abort nukes the _v_foo attribute...
self.failIf(hasattr(self.folder, '_v_foo')) self.failIf(hasattr(self.folder, '_v_foo'))
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment