Commit 6a406941 authored by Hanno Schlichting's avatar Hanno Schlichting

Whitespace and remove some code fossils

parent 53e652e0
...@@ -11,8 +11,7 @@ ...@@ -11,8 +11,7 @@
# #
############################################################################## ##############################################################################
"""Unittests for Catalog brains """Unittests for Catalog brains
"""
$Id$"""
import unittest import unittest
import Acquisition import Acquisition
...@@ -35,20 +34,20 @@ class Conflicter(Happy): ...@@ -35,20 +34,20 @@ class Conflicter(Happy):
"""Object that raises ConflictError when accessed""" """Object that raises ConflictError when accessed"""
def check(self): def check(self):
raise ConflictError raise ConflictError
class DummyRequest(Acquisition.Implicit): class DummyRequest(Acquisition.Implicit):
def physicalPathToURL(self, path, relative=False): def physicalPathToURL(self, path, relative=False):
if not relative: if not relative:
path = 'http://superbad.com' + path path = 'http://superbad.com' + path
return path return path
_marker = object() _marker = object()
class DummyCatalog(Acquisition.Implicit): class DummyCatalog(Acquisition.Implicit):
_objs = {'/happy':Happy('happy'), _objs = {'/happy':Happy('happy'),
'/secret':Secret('secret'), '/secret':Secret('secret'),
'/conflicter':Conflicter('conflicter')} '/conflicter':Conflicter('conflicter')}
_paths = _objs.keys() + ['/zonked'] _paths = _objs.keys() + ['/zonked']
_paths.sort() _paths.sort()
...@@ -71,26 +70,26 @@ class DummyCatalog(Acquisition.Implicit): ...@@ -71,26 +70,26 @@ class DummyCatalog(Acquisition.Implicit):
if default is not _marker: if default is not _marker:
return default return default
raise raise
def getpath(self, rid): def getpath(self, rid):
return self._paths[rid] return self._paths[rid]
def getobject(self, rid): def getobject(self, rid):
return self.restrictedTraverse(self._paths[rid]) return self.restrictedTraverse(self._paths[rid])
def resolve_url(self, path, REQUEST): def resolve_url(self, path, REQUEST):
path = path[path.find('/', path.find('//')+1):] # strip server part path = path[path.find('/', path.find('//')+1):] # strip server part
return self.restrictedTraverse(path) return self.restrictedTraverse(path)
class ConflictingCatalog(DummyCatalog): class ConflictingCatalog(DummyCatalog):
def getpath(self, rid): def getpath(self, rid):
raise ConflictError raise ConflictError
class BrainsTestBase: class BrainsTestBase:
_old_flag = None _old_flag = None
def setUp(self): def setUp(self):
self.cat = DummyCatalog() self.cat = DummyCatalog()
self.cat.REQUEST = DummyRequest() self.cat.REQUEST = DummyRequest()
...@@ -108,7 +107,7 @@ class BrainsTestBase: ...@@ -108,7 +107,7 @@ class BrainsTestBase:
def _restore_getOb_flag(self): def _restore_getOb_flag(self):
from Products.ZCatalog import CatalogBrains from Products.ZCatalog import CatalogBrains
CatalogBrains.GETOBJECT_RAISES = self._old_flag CatalogBrains.GETOBJECT_RAISES = self._old_flag
def _makeBrain(self, rid): def _makeBrain(self, rid):
from Products.ZCatalog.CatalogBrains import AbstractCatalogBrain from Products.ZCatalog.CatalogBrains import AbstractCatalogBrain
class Brain(AbstractCatalogBrain): class Brain(AbstractCatalogBrain):
...@@ -120,38 +119,38 @@ class BrainsTestBase: ...@@ -120,38 +119,38 @@ class BrainsTestBase:
self.failUnless(b.has_key('test_field')) self.failUnless(b.has_key('test_field'))
self.failUnless(b.has_key('data_record_id_')) self.failUnless(b.has_key('data_record_id_'))
self.failIf(b.has_key('godel')) self.failIf(b.has_key('godel'))
def testGetPath(self): def testGetPath(self):
b = [self._makeBrain(rid) for rid in range(3)] b = [self._makeBrain(rid) for rid in range(3)]
self.assertEqual(b[0].getPath(), '/conflicter') self.assertEqual(b[0].getPath(), '/conflicter')
self.assertEqual(b[1].getPath(), '/happy') self.assertEqual(b[1].getPath(), '/happy')
self.assertEqual(b[2].getPath(), '/secret') self.assertEqual(b[2].getPath(), '/secret')
def testGetPathPropagatesConflictErrors(self): def testGetPathPropagatesConflictErrors(self):
self.cat = ConflictingCatalog() self.cat = ConflictingCatalog()
b = self._makeBrain(0) b = self._makeBrain(0)
self.assertRaises(ConflictError, b.getPath) self.assertRaises(ConflictError, b.getPath)
def testGetURL(self): def testGetURL(self):
b = self._makeBrain(0) b = self._makeBrain(0)
self.assertEqual(b.getURL(), 'http://superbad.com/conflicter') self.assertEqual(b.getURL(), 'http://superbad.com/conflicter')
def testGetRID(self): def testGetRID(self):
b = self._makeBrain(42) b = self._makeBrain(42)
self.assertEqual(b.getRID(), 42) self.assertEqual(b.getRID(), 42)
def testGetObjectHappy(self): def testGetObjectHappy(self):
b = self._makeBrain(1) b = self._makeBrain(1)
self.assertEqual(b.getPath(), '/happy') self.assertEqual(b.getPath(), '/happy')
self.failUnless(b.getObject().aq_base is self.cat.getobject(1).aq_base) self.failUnless(b.getObject().aq_base is self.cat.getobject(1).aq_base)
def testGetObjectPropagatesConflictErrors(self): def testGetObjectPropagatesConflictErrors(self):
b = self._makeBrain(0) b = self._makeBrain(0)
self.assertEqual(b.getPath(), '/conflicter') self.assertEqual(b.getPath(), '/conflicter')
self.assertRaises(ConflictError, b.getObject) self.assertRaises(ConflictError, b.getObject)
class TestBrains(BrainsTestBase, unittest.TestCase): class TestBrains(BrainsTestBase, unittest.TestCase):
def _flag_value(self): def _flag_value(self):
return True return True
...@@ -160,16 +159,16 @@ class TestBrains(BrainsTestBase, unittest.TestCase): ...@@ -160,16 +159,16 @@ class TestBrains(BrainsTestBase, unittest.TestCase):
b = self._makeBrain(2) b = self._makeBrain(2)
self.assertEqual(b.getPath(), '/secret') self.assertEqual(b.getPath(), '/secret')
self.assertRaises(Unauthorized, b.getObject) self.assertRaises(Unauthorized, b.getObject)
def testGetObjectRaisesNotFoundForMissing(self): def testGetObjectRaisesNotFoundForMissing(self):
from zExceptions import NotFound from zExceptions import NotFound
b = self._makeBrain(3) b = self._makeBrain(3)
self.assertEqual(b.getPath(), '/zonked') self.assertEqual(b.getPath(), '/zonked')
self.assertRaises(KeyError, self.cat.getobject, 3) self.assertRaises(KeyError, self.cat.getobject, 3)
self.assertRaises((NotFound, AttributeError, KeyError), b.getObject) self.assertRaises((NotFound, AttributeError, KeyError), b.getObject)
class TestBrainsOldBehavior(BrainsTestBase, unittest.TestCase): class TestBrainsOldBehavior(BrainsTestBase, unittest.TestCase):
def _flag_value(self): def _flag_value(self):
return False return False
...@@ -177,18 +176,15 @@ class TestBrainsOldBehavior(BrainsTestBase, unittest.TestCase): ...@@ -177,18 +176,15 @@ class TestBrainsOldBehavior(BrainsTestBase, unittest.TestCase):
b = self._makeBrain(2) b = self._makeBrain(2)
self.assertEqual(b.getPath(), '/secret') self.assertEqual(b.getPath(), '/secret')
self.assertEqual(b.getObject(), None) self.assertEqual(b.getObject(), None)
def testGetObjectReturnsNoneForMissing(self): def testGetObjectReturnsNoneForMissing(self):
b = self._makeBrain(3) b = self._makeBrain(3)
self.assertEqual(b.getPath(), '/zonked') self.assertEqual(b.getPath(), '/zonked')
self.assertRaises(KeyError, self.cat.getobject, 3) self.assertRaises(KeyError, self.cat.getobject, 3)
self.assertEqual(b.getObject(), None) self.assertEqual(b.getObject(), None)
def test_suite(): def test_suite():
suite = unittest.TestSuite() suite = unittest.TestSuite()
suite.addTest(unittest.makeSuite(TestBrains)) suite.addTest(unittest.makeSuite(TestBrains))
suite.addTest(unittest.makeSuite(TestBrainsOldBehavior)) suite.addTest(unittest.makeSuite(TestBrainsOldBehavior))
return suite return suite
if __name__ == '__main__':
unittest.main(defaultTest='test_suite')
...@@ -259,7 +259,7 @@ class TestZCatalog(unittest.TestCase): ...@@ -259,7 +259,7 @@ class TestZCatalog(unittest.TestCase):
self._catalog.reindexIndex('title', {}) self._catalog.reindexIndex('title', {})
data = self._catalog.getMetadataForUID('0') data = self._catalog.getMetadataForUID('0')
self.assertEqual(data['title'], '0') self.assertEqual(data['title'], '0')
def testReindexIndexesFalse(self): def testReindexIndexesFalse(self):
# setup # setup
false_id = self.upper + 1 false_id = self.upper + 1
...@@ -873,6 +873,3 @@ def test_suite(): ...@@ -873,6 +873,3 @@ def test_suite():
suite.addTest( unittest.makeSuite( TestMerge ) ) suite.addTest( unittest.makeSuite( TestMerge ) )
suite.addTest( unittest.makeSuite( TestZCatalogGetObject ) ) suite.addTest( unittest.makeSuite( TestZCatalogGetObject ) )
return suite return suite
if __name__ == '__main__':
unittest.main(defaultTest='test_suite')
...@@ -11,8 +11,7 @@ ...@@ -11,8 +11,7 @@
# #
############################################################################## ##############################################################################
"""Unittests for Lazy sequence classes """Unittests for Lazy sequence classes
"""
$Id$"""
import unittest import unittest
...@@ -60,7 +59,7 @@ class TestLazyCat(BaseSequenceTest): ...@@ -60,7 +59,7 @@ class TestLazyCat(BaseSequenceTest):
seq3 = list(letters) seq3 = list(letters)
lcat = apply(self._createLSeq, lcat = apply(self._createLSeq,
[self._createLSeq(seq) for seq in (seq1, seq2, seq3)]) [self._createLSeq(seq) for seq in (seq1, seq2, seq3)])
self._compare(lcat[5:-5], seq1[5:] + seq2 + seq3[:-5]) self._compare(lcat[5:-5], seq1[5:] + seq2 + seq3[:-5])
def testConsistentLength(self): def testConsistentLength(self):
# Unaccessed length # Unaccessed length
...@@ -102,7 +101,7 @@ class TestLazyMap(TestLazyCat): ...@@ -102,7 +101,7 @@ class TestLazyMap(TestLazyCat):
class TestLazyFilter(TestLazyCat): class TestLazyFilter(TestLazyCat):
def _createLSeq(self, *seq): def _createLSeq(self, *seq):
return self._createLFilter(lambda x: True, *seq) return self._createLFilter(lambda x: True, *seq)
def _createLFilter(self, filter, *seq): def _createLFilter(self, filter, *seq):
from Products.ZCatalog.Lazy import LazyFilter from Products.ZCatalog.Lazy import LazyFilter
totalseq = [] totalseq = []
...@@ -162,7 +161,7 @@ class TestLazyMop(TestLazyCat): ...@@ -162,7 +161,7 @@ class TestLazyMop(TestLazyCat):
def testConsistentLengthWithMop(self): def testConsistentLengthWithMop(self):
from string import letters from string import letters
seq = range(10) + list(letters) seq = range(10) + list(letters)
def filter(x): def filter(x):
if isinstance(x, int): if isinstance(x, int):
...@@ -214,6 +213,3 @@ def test_suite(): ...@@ -214,6 +213,3 @@ def test_suite():
suite.addTest(unittest.makeSuite(TestLazyMop)) suite.addTest(unittest.makeSuite(TestLazyMop))
suite.addTest(unittest.makeSuite(TestLazyValues)) suite.addTest(unittest.makeSuite(TestLazyValues))
return suite return suite
if __name__ == '__main__':
unittest.main(defaultTest='test_suite')
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment