Fix wrapping of pointer types.

Of course it's "cdef char *foo()" not "cdef char* foo()"

Cython/Compiler/Nodes.py

@@ -1271,13 +1271,12 @@ class CVarDefNode(StatNode):
                     "Non-trivial type declarators in shared declaration (e.g. mix of pointers and values). " +
                     "Each pointer declaration should be on its own line.", 1)
 
-            create_extern_wrapper = False
+            create_extern_wrapper = (self.overridable
+                                        and self.visibility == 'extern'
+                                        and env.is_module_scope)
+            if create_extern_wrapper:
+                declarator.overridable = False
             if isinstance(declarator, CFuncDeclaratorNode):
-                create_extern_wrapper = (self.overridable
-                                            and self.visibility == 'extern'
-                                            and env.is_module_scope)
-                if create_extern_wrapper:
-                    declarator.overridable = False
                 name_declarator, type = declarator.analyse(base_type, env, directive_locals=self.directive_locals)
             else:
                 name_declarator, type = declarator.analyse(base_type, env)

Cython/Compiler/PyrexTypes.py

@@ -1236,7 +1236,10 @@ class CConstType(BaseType):
 
     def declaration_code(self, entity_code,
             for_display = 0, dll_linkage = None, pyrex = 0):
-        return self.const_base_type.declaration_code("const %s" % entity_code, for_display, dll_linkage, pyrex)
+        if for_display or pyrex:
+            return "const " + self.const_base_type.declaration_code(entity_code, for_display, dll_linkage, pyrex)
+        else:
+            return self.const_base_type.declaration_code("const %s" % entity_code, for_display, dll_linkage, pyrex)
 
     def specialize(self, values):
         base_type = self.const_base_type.specialize(values)

tests/run/cpdef_extern_func.pxd

+# cython: c_string_type=str
+# cython: c_string_encoding=ascii
+
 cdef extern from "math.h":
     cpdef double pxd_sqrt "sqrt"(double)

tests/run/cpdef_extern_func.pyx

+# cython: c_string_type=str
+# cython: c_string_encoding=ascii
+
 __doc__ = """
 >>> sqrt(1)
 1.0
@@ -7,10 +10,17 @@ __doc__ = """
 3.0
 >>> log(10)
 Traceback (most recent call last):
+...
 NameError: name 'log' is not defined
+
+>>> strchr('abcabc', ord('c'))
+'cabc'
 """
 
 cdef extern from "math.h":
     cpdef double sqrt(double)
     cpdef double pyx_sqrt "sqrt"(double)
     cdef double log(double) # not wrapped
+
+cdef extern from "string.h":
+    cpdef char* strchr(const char *haystack, int needle);