More fixes for pylint 2.0.dev2

ci-requirements.txt

@@ -10,7 +10,7 @@ Cython >= 0.28.1
 # Python 3.7b1 requires this.
 greenlet>=0.4.13 ; platform_python_implementation == "CPython"
 pylint>=1.8.0 ; python_version < "3.4"
-pylint >= 2.0.0.dev1 ; python_version >= "3.4"
+pylint >= 2.0.0.dev2 ; python_version >= "3.4"
 # pylint 2 needs astroid 2; unfortunately, it uses `typed_ast`
 # which has a C extension that doesn't build on PyPy
 astroid >= 2.0.0.dev1 ; python_version >= "3.4" and platform_python_implementation == "CPython"

src/gevent/_ffi/loop.py

@@ -428,7 +428,7 @@ class AbstractLoop(object):
             expiration = now + getswitchinterval()
             self._stop_callback_timer()
             while self._callbacks:
-                cb = self._callbacks.popleft()
+                cb = self._callbacks.popleft() # pylint:disable=assignment-from-no-return
                 count -= 1
                 self.unref() # XXX: libuv doesn't have a global ref count!
                 callback = cb.callback
@@ -686,7 +686,7 @@ class AbstractLoop(object):
 
     def _format_details(self):
         msg = ''
-        fileno = self.fileno()
+        fileno = self.fileno() # pylint:disable=assignment-from-none
         try:
             activecnt = self.activecnt
         except AttributeError:

src/gevent/_tblib.py

@@ -30,6 +30,7 @@ Taken verbatim from Jinja2.
 
 https://github.com/mitsuhiko/jinja2/blob/master/jinja2/debug.py#L267
 """
+# pylint:disable=consider-using-dict-comprehension
 #import platform # XXX: gevent cannot import platform at the top level; interferes with monkey patching
 import sys
 

src/gevent/_threading.py

@@ -24,6 +24,10 @@ start_new_thread, Lock, get_thread_ident, = monkey.get_original(thread_mod_name,
 ])
 
 
+# pylint 2.0.dev2 things collections.dequeue.popleft() doesn't return
+# pylint:disable=assignment-from-no-return
+
+
 class _Condition(object):
     # pylint:disable=method-hidden
 

src/gevent/libev/corecffi.py

@@ -279,7 +279,7 @@ class loop(AbstractLoop):
     def destroy(self):
         if self._ptr:
             super(loop, self).destroy()
-
+            # pylint:disable=comparison-with-callable
             if globals()["__SYSERR_CALLBACK"] == self._handle_syserr:
                 set_syserr_cb(None)
 

src/gevent/queue.py

@@ -56,6 +56,9 @@ if hasattr(__queue__, 'SimpleQueue'):
 __all__ = __implements__ + __extensions__ + __imports__
 
 
+# pylint 2.0.dev2 things collections.dequeue.popleft() doesn't return
+# pylint:disable=assignment-from-no-return
+
 def _safe_remove(deq, item):
     # For when the item may have been removed by
     # Queue._unlock