Commit c487e480 authored by Jason Madden's avatar Jason Madden

patch out test_ssl.NetworkedBIOTests.test_handshake.

I see in on OS X even without gevent involved. I see it with gevent involved both on the sendall branch and the master branch. I see it on Travis (now) with the sendall patch.
I don't know if it's been seen before the sendall patch on Travis---flaky builds tend to get rerun. None of the other SSL tests are failing, though, and the pypy version of test_ssl.py notes that test_handshake has been removed from CPython altogether.
It looks like it's very dependent on buffering and things like that.
parent d016e9f8
...@@ -643,6 +643,12 @@ if PYPY and sys.pypy_version_info[:4] in ( # pylint:disable=no-member ...@@ -643,6 +643,12 @@ if PYPY and sys.pypy_version_info[:4] in ( # pylint:disable=no-member
# This has the wrong constants in 5.8 (but worked in 5.7), at least on # This has the wrong constants in 5.8 (but worked in 5.7), at least on
# OS X. It finds "zlib compression" but expects "ZLIB". # OS X. It finds "zlib compression" but expects "ZLIB".
'test_ssl.ThreadedTests.test_compression', 'test_ssl.ThreadedTests.test_compression',
# The below are new with 5.10.1
# This gets an EOF in violation of protocol; again, even without gevent
# (at least on OS X; it's less consistent about that on travis)
'test_ssl.NetworkedBIOTests.test_handshake',
] ]
if OSX: if OSX:
...@@ -673,9 +679,6 @@ if PYPY and sys.pypy_version_info[:4] in ( # pylint:disable=no-member ...@@ -673,9 +679,6 @@ if PYPY and sys.pypy_version_info[:4] in ( # pylint:disable=no-member
'test_ssl.ThreadedTests.test_protocol_tlsv1', 'test_ssl.ThreadedTests.test_protocol_tlsv1',
'test_ssl.ThreadedTests.test_protocol_tlsv1_1', 'test_ssl.ThreadedTests.test_protocol_tlsv1_1',
# This gets an EOF in violation of protocol; again, even without gevent
'test_ssl.NetworkedBIOTests.test_handshake',
# This gets None instead of http1.1, even without gevent # This gets None instead of http1.1, even without gevent
'test_ssl.ThreadedTests.test_npn_protocols', 'test_ssl.ThreadedTests.test_npn_protocols',
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment