• Douwe Maan's avatar
    Merge branch 'rs-issue-15126' into 'master' · 70ada081
    Douwe Maan authored
    Remove persistent XSS vulnerability in `commit_person_link` helper
    
    Because we were incorrectly supplying the tooltip title as
    `data-original-title` (which Bootstrap's Tooltip JS automatically
    applies based on the `title` attribute; we should never be setting it
    directly), the value was being passed through as-is.
    
    Instead, we should be supplying the normal `title` attribute and letting
    Rails escape the value, which also negates the need for us to call
    `sanitize` on it.
    
    Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/15126
    
    See merge request !1948
    Signed-off-by: default avatarRémy Coutable <remy@rymai.me>
    70ada081
projects_helper.rb 9.36 KB