Merge branch 'rs-fix-application-helper-specs' into 'master'

Fix ApplicationHelper specs

On current `master` if you run these specs by themselves, they fail. I have no idea why they work when run with other specs, but now they work all the time.

- Use the `helper` object, as per RSpec 3 standards
- Use `assign` to assign instance variables that helpers expect
- Add `StubConfiguration` support module

See merge request !906

spec/spec_helper.rb

@@ -13,12 +13,12 @@ RSpec.configure do |config|
   config.use_instantiated_fixtures  = false
   config.mock_with :rspec
 
-  config.include LoginHelpers, type: :feature
-  config.include LoginHelpers, type: :request
-  config.include FactoryGirl::Syntax::Methods
   config.include Devise::TestHelpers, type: :controller
-
+  config.include LoginHelpers,        type: :feature
+  config.include LoginHelpers,        type: :request
+  config.include StubConfiguration
   config.include TestEnv
+
   config.infer_spec_type_from_file_location!
   config.raise_errors_for_deprecations!
 

spec/support/factory_girl.rb

+RSpec.configure do |config|
+  config.include FactoryGirl::Syntax::Methods
+end

spec/support/stub_configuration.rb

+module StubConfiguration
+  def stub_application_setting(messages)
+    allow(Gitlab::CurrentSettings.current_application_settings).
+      to receive_messages(messages)
+  end
+
+  def stub_config_setting(messages)
+    allow(Gitlab.config.gitlab).to receive_messages(messages)
+  end
+
+  def stub_gravatar_setting(messages)
+    allow(Gitlab.config.gravatar).to receive_messages(messages)
+  end
+end