Merge branch 'improve-gitlab-test' into 'master'

Improve rake test

Check for `system` call return value instead of `$?.exitstatus`

lib/tasks/gitlab/test.rake

@@ -8,9 +8,7 @@ namespace :gitlab do
     ]
 
     cmds.each do |cmd|
-      result = system({'RAILS_ENV' => 'test', 'force' => 'yes'}, *cmd)
-
-      raise "#{cmd} failed!" unless result
+      system({'RAILS_ENV' => 'test', 'force' => 'yes'}, *cmd) or raise("#{cmd} failed!")
     end
   end
-end
+end
\ No newline at end of file

lib/tasks/spec.rake

@@ -40,7 +40,6 @@ end
 
 def run_commands(cmds)
   cmds.each do |cmd|
-    system({'RAILS_ENV' => 'test', 'force' => 'yes'}, *cmd)
-    raise "#{cmd} failed!" unless $?.exitstatus.zero?
+    system({'RAILS_ENV' => 'test', 'force' => 'yes'}, *cmd) or raise("#{cmd} failed!")
   end
 end

lib/tasks/spinach.rake

@@ -8,7 +8,6 @@ task :spinach do
   ]
 
   cmds.each do |cmd|
-    system({'RAILS_ENV' => 'test', 'force' => 'yes'}, *cmd)
-    raise "#{cmd} failed!" unless $?.exitstatus.zero?
+    system({'RAILS_ENV' => 'test', 'force' => 'yes'}, *cmd) or raise("#{cmd} failed!")
   end
 end