1. 28 Apr, 2016 1 commit
    • Connor Shea's avatar
      Enable LstripRstrip cop · 267dd233
      Connor Shea authored
      This requires no code changes since it doesn't actually change anything
      in the codebase, just preventative.
      267dd233
  2. 27 Apr, 2016 9 commits
    • Jacob Schatz's avatar
      Merge branch 'add-js-prefix-to-user-tab-classes' into 'master' · a792427e
      Jacob Schatz authored
      Add JS prefix to user tab classes
      
      ## What does this MR do
      
      This MR adds the `js-` prefix to the classes which are used for js purposes only. This MR only affects the said classes inside `users/show.html.haml`.
      
      ## Are there points in the code the reviewer needs to double check?
      
      I'm not entirely sure if this project uses the `js-` prefix for
      classes that are used for js purposes only. Doing a grep shows some of the classes have the prefix, but I'm still unsure whether this project follows this rule.
      
      ## Why was this MR needed?
      
      As I was working thru #13401, I wanted to add a tab on the user profile page to show the contributions outside the GitLab instance. Reading the JS, I came across this. This MR helps new people reading the code that the said classes are for js purposes only. Also, it helps the project work toward to uniform class naming.
      
      I suggest that we document adding the `js-` prefix to classes for js purposes only (if this is the case for this project)
      
      See merge request !3928
      a792427e
    • Achilleas Pipinellis's avatar
      Merge branch 'trigger-query-string' into 'master' · 2ec58d4a
      Achilleas Pipinellis authored
      Add API doc example with query string for triggering build
      
      Make this explicit to prevent confusion as we saw in gitlab-org/gitlab-ci#413.
      
      See merge request !3947
      2ec58d4a
    • Achilleas Pipinellis's avatar
      Merge branch 'fix-operations-doc' into 'master' · 0863644a
      Achilleas Pipinellis authored
      Sidekiq MemoryKiller sends a `SIGKILL` signal, not `SIGTERM`
      
      As documented in https://gitlab.com/gitlab-org/gitlab-ce/blob/f127edd012bd8b6f76ac67d69aadbd7d4837258f/lib/gitlab/sidekiq_middleware/memory_killer.rb#L10 (this was changed by c291ff9c).
      
      See merge request !3927
      0863644a
    • Jacob Schatz's avatar
      Merge branch 'project-dropdown-tests' into 'master' · 90c96650
      Jacob Schatz authored
      Project title dropdown tests
      
      Added a test for when on an issue page to check whether the project
      dropdown links will still work
      
      See !3870
      
      See merge request !3921
      90c96650
    • Jacob Schatz's avatar
      Merge branch 'sidebar-label-link' into 'master' · 1b35955e
      Jacob Schatz authored
      Updated label links to work correctly for filtering
      
      See !3846#note_5033951
      
      See merge request !3920
      1b35955e
    • Jacob Schatz's avatar
      Merge branch 'esc-close-dropdown' into 'master' · 7640e60a
      Jacob Schatz authored
      Escape key closes the dropdown
      
      Fixes #15432 
      
      ![esc](/uploads/067e32bcaf265c3241d84dcbd3f11532/esc.gif)
      
      See merge request !3904
      7640e60a
    • David de Boer's avatar
    • Dmitriy Zaporozhets's avatar
      Merge branch 'ie-browser-update' into 'master' · 6c0ed639
      Dmitriy Zaporozhets authored
      Changes support from IE 10+ to IE 11+
      
      IE 11 was released 17 October 2013; 2 years ago. Generally what I have experienced is that support for browsers (when newer ones are available) continues for up to 2 years. Based on that info we would drop support for IE 10 and the latest IE we would support would be IE 11. 
      
      I also think this is more realistic since no one is really testing anything on IE 10 at the moment.  We should start testing on all the browser that we currently support. 
      
      Also we can then have real support for flexbox and not need things like `-ms-flexbox` and other IE specific hacks. 
      
      cc @iamphill @annabeldunstone @elvongray @alfredo1 @rspeicher 
      
      See merge request !3913
      6c0ed639
    • Dmitriy Zaporozhets's avatar
      Merge branch 'rs-letter_opener_web' into 'master' · 47d269c1
      Dmitriy Zaporozhets authored
      Add letter_opener_web gem
      
      Sent emails in the development environment will no longer automatically
      be opened in the browser. If a sent email needs to be viewed, it can be
      found at the `/rails/letter_opener` route.
      
      See merge request !3893
      47d269c1
  3. 26 Apr, 2016 30 commits