Merge branch 'fix/exec_with_ld_library_path' into 'master'

Pass LD_LIBRARY_PATH to the git command

As gitlab-shell does in https://gitlab.com/gitlab-org/gitlab-shell/blob/master/lib/gitlab_shell.rb#L126

LD_LIBRARY_PATH is needed when using Software Collections for instance but there are probably many other scenarios that need it as well. It was passed to git (and from git to hooks) by gitlab-shell, and still is for SSH access, but it was not the case anymore for HTTP access with the introduction of gitlab-git-http-server/git-workhorse.


See merge request !1

helpers.go

@@ -30,6 +30,7 @@ func gitCommand(gl_id string, name string, args ...string) *exec.Cmd {
 	// Explicitly set the environment for the Git command
 	cmd.Env = []string{
 		fmt.Sprintf("PATH=%s", os.Getenv("PATH")),
+		fmt.Sprintf("LD_LIBRARY_PATH=%s", os.Getenv("LD_LIBRARY_PATH")),
 		fmt.Sprintf("GL_ID=%s", gl_id),
 	}
 	// If we don't do something with cmd.Stderr, Git errors will be lost