Change-Id: I7e9b530906c233f7fcdac434984b9051acb7dbb9

Go 1.20 was released in February - 4 months ago:

https://go.dev/doc/devel/release

Change-Id: Id24b29f3f7009d34b3ec082adf623dfc41431876

In https://github.com/hanwen/go-fuse/commit/90b055af4668fce08c961406c32c15bbd7953fe4 we adjusted go-fuse to support fusermount
string options with commas and backslash. But https://github.com/hanwen/go-fuse/commit/90b055af4668fce08c961406c32c15bbd7953fe4
only verified that commas and backslashs work with fusermount and
missed checking if they also work when using 'DirectMount'.

Initially this may not look problematic, because the option string escaping
with backslashs is only applied when mounting with fusermount and isn't
applied when directly mounting [1].

But https://github.com/hanwen/go-fuse/commit/90b055af4668fce08c961406c32c15bbd7953fe4 also dropped an explicit check for commas [2]
which would have been applied independently from whether 'DirectMount' is
set or not. In other words, the previous patch changed go-fuse to allow commas
and backslashs in option strings for 'DirectMount' or fusermount, but missed
checking if commas/backslashs actually works with 'DirectMount'.

This patch therefore amends 'TestDirectMount' to ensure commas and
backslashs work in the 'fsname' option when 'DirectMount' is used.

[1] https://github.com/hanwen/go-fuse/blob/90b055a/fuse/mount_linux.go#L107
[2] https://github.com/hanwen/go-fuse/blob/854d591/fuse/server.go#L188-L192

Change-Id: I78c612c55fb08be66713cd5234a8ffd468dd1349

Before this patch no commas were allowed in any fusermount option string.
But it is in fact possible to use commas in fusermount options: we only
need to escape them [1].

Now go-fuse users can use commas in fusermount options.

Related libfuse commits are [1] and [2].

This patch also adds a test which ensures neither go-fuse nor fusermount
crash if we pass options with commas.

---

[1] https://github.com/libfuse/libfuse/commit/555d6b504308eac6b976321ce938ee4bec62c354
[2] https://github.com/libfuse/libfuse/commit/5c094ac0150ebfef6a2c9c2c9d1c545a90ff4e96

Change-Id: Iadf8283e630dc1fb884d047d8765eeaaca90eabd

Change-Id: I2aacf5775033dae03772d87b4a5c3f15bd961aff

Change-Id: Idf8f8f08849b279f1c8a346112d43e0eb44f9810

Change-Id: I48236bf879939537944e617baa620884e7601055

Change-Id: Ide68c48ffc2b8343884639835b958bf404739dbc

Change-Id: Ib86b9b98ce62783992ed233fe809f3552dc7bd99

A spurious blank line dropped the entire doc string.

Set Size in the Lookup example

Change-Id: Idefd113f7749e8aadfc4730e38b7444f36c0e419

Fixes this test failure:

2023/04/13 20:25:20 callFusermount: executing ["/usr/bin/fusermount3" "/tmp/TestDirectMount4166040800" "-o" "allow_other,subtype=/tmp/go-build1065896,max_read=131072"]
/usr/bin/fusermount3: option allow_other only allowed if 'user_allow_other' is set in /etc/fuse.conf

\--- FAIL: TestDirectMount (0.01s)
    mount_linux_test.go:117: fusermount exited with code 256

Change-Id: I4a2a2983dd422de9360b17068ac0d8a3947d453d

Change-Id: Ifb84efcb76615cc492c867afb9e1840a6977d402

Commit 265a3926 missed
adding max_read to the DirectMount path.

Add it, which fixes the TestDirectMount failures.

Change-Id: Ie934944d8f0a08fb65e2b6f675c8032f404d50df

Also test several max_write values, and different fs names.
And make the fail output easier to read.

Change-Id: Idbc9003554dfd7320890488f0b16cd5cfce1d6b4

Change-Id: I1d0537a1f50eb850c7741db1253189dfcf81711c

Change-Id: Iee1d90c83a1ff41dadbea07259e71fde7b0cfb22

Change-Id: Ieba742bdbe830fdc18f82986694e2cd4d7caf161

According to the lseek(2) manpage, seek(SEEK_HOLE) should behave as if
there is an implicit hole at the end of every file.

Add a test.

Fixes #417.

Change-Id: I169a803ea81e3c920b61edf8bb8b774870d042c5

Add a test.

Change-Id: I8620e59ce2fc7b19f595c5670839735243fcd1bf

Previously, if a DirStream.Next() call would return error, we would
return the buffered data as well as the errno code in the same
request.

This would confuse the kernel, who interprets this as an invalid
response, returning syscall.EIO to the caller.

To fix this, also buffer the errno as overflow entry in the fileEntry
struct. When we encounter an error, return thus far read entries with
success. The following read contains just the error.

For testing this properly, loopbackDirStream (which reads directory
contents) must also buffer error returns.

Change-Id: Ideb8ea6f540de9189a0f366efca0db2205e5dec3

Adds fuse.Options.EnableSymlinkCaching to enable cached
symlinks. Updates in GETATTR results do not trigger new READLINK
calls, so this breaks backward compatibility for file systems that
have auto-updating symlinks (e.g. a symlink pointing to the HEAD
revision of a remote git repository)

Change-Id: Ifcbcd75e

The logging makes it seems something is wrong when running the test.

Change-Id: I4e8ec5c72da555922ca7d20f0a34b9939b36fa9a

This avoids a deadlock on Darwin, because futimens calls
loopbackFile.Getattr again.

Fixes #419

Change-Id: Ia45a0ec3c0ea06c0419913e34b3415808f9349da

Change-Id: I9357f137487d1c958a95ed46db081b7775604b6b

Change-Id: Ifec1f504e014c3af9fe79943660831be0598a6d2

Change-Id: Ia0d7293d14bb4fdac9be913ba6bd92b836636070

Change-Id: I115ebce34aaf22767bb8b90b842927c133e30b65

This avoids that the result from concurrent directory reads (which
would return entries in different order) pollute kernel caches. Add a
test.

Fixes #391

Change-Id: I06a252bd

Change-Id: I144cb541

Change-Id: I1612f912dd6b113e7776b13c40f9a41038a3fd53

Signed-off-by: Alex Fishman <alex@fuse-t.org>
Change-Id: I82de5e2dd0340da4e05e4ccf1bbd162dff33b656

Darwin amd64 uses uint16 for Stat_t.mode
Signed-off-by: Alex Fishman <alex@fuse-t.org>
Change-Id: I82de5e2dd0340da4e05e4ccf1bbd162dff33b611

Change-Id: I3a67066a6660481bdab81278a91027755973b496

- provides an optional way to set e.g. Ino and/or Gen for
  the root directory when calling fs.Mount()
- provides unit test cases
- partial fix for #399

Change-Id: If45a0ec3c0ea06c0419913e34b3415808f9349da

Allows to enable the DirectMount{,Strict} flag through the cli,
facilitating testing.

Change-Id: I46e273ea68e6a81b4e7873802bc3b1c7760f56f0

Commit

	17c7e2cd loopback: show original directory in "df"

added the FsName field to MountOptions, but looks like

	d31db957 fuse: allow setting the fsname (first column in df -T)

forgot that it exists. Use it now.

This will be important for DirectMount, as passing "fsname=xxx" to
the mount syscall causes the kernel to reject with EINVAL and this
message in dmesg:

	[132274.900267] fuse: Unknown parameter 'fsname'

Change-Id: Ic1233fe9306e2ce05f85189eecceecec2baa44b7

These were open-coded before. Pull them into the struct
initializer for somewhat clearer code.

I'm doing this now as I'm about to add another option.

Change-Id: Ie04cfc9fb1f4128b8faf5c85757d7263aa77e5a0

Do what fusermount does instead of hard-coding the strings.

Change-Id: Idf18f1c5cd17b7f9db8e15e8bc5173d0f6ca41db

Two variable were defined but never used in what looks like
a copy-paste error or something.

Fix that, which also makes the tests pass.

Change-Id: Iebf48583874977c518d888d9a80bc1f02e2a7f86

Reason for adding DirectMountStrict is making the DirectMount
functionality testable, though it may have value for the user
in some cases.

Add defaultRawFileSystem & loopback tests for DirectMount
and DirectMountStrict.

The tests fail right now due to bugs in DirectMount that will be fixed
shortly:

	go-fuse/fuse$ sudo /usr/local/go/bin/go test -run TestDirectMount
	[...]
	2022/12/28 20:19:21 mountDirect: calling syscall.Mount("", "/tmp/TestDirectMount3242971772", "fuse./tmp/go-build1215740", 0x0, "fd=7,rootmode=40000,user_id=0,group_id=0")
	2022/12/28 20:19:21 mount: failed to do direct mount: invalid argument
	[...]

Change-Id: Ibfa2fa141cb43e1f8c7319233c454a3e85fa435e