• David Crawshaw's avatar
    runtime: initialize hash algs before typemap · f135c326
    David Crawshaw authored
    When compiling with -buildmode=shared, a map[int32]*_type is created for
    each extra module mapping duplicate types back to a canonical object.
    This is done in the function typelinksinit, which is called before the
    init function that sets up the hash functions for the map
    implementation. The result is typemap becomes unusable after
    runtime initialization.
    
    The fix in this CL is to move algorithm init before typelinksinit in
    the runtime setup process. (For 1.8, we may want to turn typemap into
    a sorted slice of types and use binary search.)
    
    Manually tested on GOOS=linux with:
    
    	GOHOSTARCH=386 GOARCH=386 ./make.bash && \
    		go install -buildmode=shared std && \
    		cd ../test && \
    		go run run.go -linkshared
    
    Fixes #16590
    
    Change-Id: Idc08c50cc70d20028276fbf564509d2cd5405210
    Reviewed-on: https://go-review.googlesource.com/25469
    Run-TryBot: David Crawshaw <crawshaw@golang.org>
    Reviewed-by: default avatarKeith Randall <khr@golang.org>
    f135c326
alg.go 7.85 KB