• Filippo Valsorda's avatar
    crypto/tls: remove TestVerifyHostnameResumed · 20e4540e
    Filippo Valsorda authored
    Session resumption is not a reliable TLS behavior: the server can decide
    to reject a session ticket for a number of reasons, or no reason at all.
    This makes this non-hermetic test extremely brittle.
    
    It's currently broken on the builders for both TLS 1.2 and TLS 1.3, and
    I could reproduce the issue for TLS 1.3 only. As I was debugging it, it
    started passing entirely on my machine.
    
    In practice, it doesn't get us any coverage as resumption is already
    tested with the recorded exchange tests, and TestVerifyHostname still
    provides a smoke test checking that we can in fact talk TLS.
    
    Fixes #32978
    
    Change-Id: I63505e22ff7704f25ad700d46e4ff14850ba5d3c
    Reviewed-on: https://go-review.googlesource.com/c/go/+/186239
    Run-TryBot: Filippo Valsorda <filippo@golang.org>
    Reviewed-by: default avatarBryan C. Mills <bcmills@google.com>
    20e4540e
tls_test.go 30.2 KB