• lukechampine's avatar
    crypto/ed25519: outline NewKeyFromSeed and Sign · 2dfff363
    lukechampine authored
    This allows the returned key/signature to be stack-allocated where possible.
    
    name              old time/op    new time/op    delta
    NewKeyFromSeed-4    61.8µs ± 8%    57.2µs ±11%      ~     (p=0.056 n=5+5)
    Signing-4           56.6µs ± 3%    67.8µs ±38%      ~     (p=1.000 n=5+5)
    
    name              old alloc/op   new alloc/op   delta
    NewKeyFromSeed-4     64.0B ± 0%      0.0B       -100.00%  (p=0.008 n=5+5)
    Signing-4             512B ± 0%      448B ± 0%   -12.50%  (p=0.008 n=5+5)
    
    name              old allocs/op  new allocs/op  delta
    NewKeyFromSeed-4      1.00 ± 0%      0.00       -100.00%  (p=0.008 n=5+5)
    Signing-4             6.00 ± 0%      5.00 ± 0%   -16.67%  (p=0.008 n=5+5)
    
    Change-Id: I7dc6a1b8a483c4b213f380ac7c30cefc5caca0f9
    GitHub-Last-Rev: 0dd2e0f93e9cd1410760544be638238f18fa5cd4
    GitHub-Pull-Request: golang/go#34357
    Reviewed-on: https://go-review.googlesource.com/c/go/+/195980Reviewed-by: default avatarFilippo Valsorda <filippo@golang.org>
    Run-TryBot: Filippo Valsorda <filippo@golang.org>
    TryBot-Result: Gobot Gobot <gobot@golang.org>
    2dfff363
ed25519.go 6.59 KB