• Cuong Manh Le's avatar
    runtime: fix unsafe.Pointer alignment on Linux · 2e1a6a28
    Cuong Manh Le authored
    Caught by go test -a -short -gcflags=all=-d=checkptr runtime
    
    TestMincoreErrorSign intentionally uses uintptr(1) to get -EINVAL,
    but it violates unsafe pointer rules 2. So use another misaligned
    pointer add(new(int32), 1), but do not violate unsafe pointer rules.
    
    TestEpollctlErrorSign passes an unsafe.Pointer of &struct{}{} to
    Epollctl, which is then casted to epollevent, causes mis-alignment.
    Fixing it by exporting epollevent on runtime_test package, so it can be
    passed to Epollctl.
    
    Updates #34972
    
    Change-Id: I78ebfbeaf706fd1d372272af0bbc4e2cabca4631
    Reviewed-on: https://go-review.googlesource.com/c/go/+/202157
    Run-TryBot: Cuong Manh Le <cuong.manhle.vn@gmail.com>
    Reviewed-by: default avatarMatthew Dempsky <mdempsky@google.com>
    TryBot-Result: Gobot Gobot <gobot@golang.org>
    2e1a6a28
runtime_linux_test.go 1.46 KB