• Austin Clements's avatar
    runtime: make copystack/sudog synchronization more explicit · 36a432f2
    Austin Clements authored
    When we copy a stack of a goroutine blocked in a channel operation, we
    have to be very careful because other goroutines may be writing to
    that goroutine's stack. To handle this, stack copying acquires the
    locks for the channels a goroutine is waiting on.
    
    One complication is that stack growth may happen while a goroutine
    holds these locks, in which case stack copying must *not* acquire
    these locks because that would self-deadlock.
    
    Currently, stack growth never acquires these locks because stack
    growth only happens when a goroutine is running, which means it's
    either not blocking on a channel or it's holding the channel locks
    already. Stack shrinking always acquires these locks because shrinking
    happens asynchronously, so the goroutine is never running, so there
    are either no locks or they've been released by the goroutine.
    
    However, we're about to change when stack shrinking can happen, which
    is going to break the current rules. Rather than find a new way to
    derive whether to acquire these locks or not, this CL simply adds a
    flag to the g struct that indicates that stack copying should acquire
    channel locks. This flag is set while the goroutine is blocked on a
    channel op.
    
    For #10958, #24543.
    
    Change-Id: Ia2ac8831b1bfda98d39bb30285e144c4f7eaf9ab
    Reviewed-on: https://go-review.googlesource.com/c/go/+/172982
    Run-TryBot: Austin Clements <austin@google.com>
    TryBot-Result: Gobot Gobot <gobot@golang.org>
    Reviewed-by: default avatarMichael Knyszek <mknyszek@google.com>
    36a432f2
select.go 13.2 KB