• Keith Randall's avatar
    cmd/compile,runtime: generate hash functions only for types which are map keys · 36f30ba2
    Keith Randall authored
    Right now we generate hash functions for all types, just in case they
    are used as map keys. That's a lot of wasted effort and binary size
    for types which will never be used as a map key. Instead, generate
    hash functions only for types that we know are map keys.
    
    Just doing that is a bit too simple, since maps with an interface type
    as a key might have to hash any concrete key type that implements that
    interface. So for that case, implement hashing of such types at
    runtime (instead of with generated code). It will be slower, but only
    for maps with interface types as keys, and maybe only a bit slower as
    the aeshash time probably dominates the dispatch time.
    
    Reorg where we keep the equals and hash functions. Move the hash function
    from the key type to the map type, saving a field in every non-map type.
    That leaves only one function in the alg structure, so get rid of that and
    just keep the equal function in the type descriptor itself.
    
    cmd/go now has 10 generated hash functions, instead of 504. Makes
    cmd/go 1.0% smaller. Update #6853.
    
    Speed on non-interface keys is unchanged. Speed on interface keys
    is ~20% slower:
    
    name                  old time/op  new time/op  delta
    MapInterfaceString-8  23.0ns ±21%  27.6ns ±14%  +20.01%  (p=0.002 n=10+10)
    MapInterfacePtr-8     19.4ns ±16%  23.7ns ± 7%  +22.48%   (p=0.000 n=10+8)
    
    Change-Id: I7c2e42292a46b5d4e288aaec4029bdbb01089263
    Reviewed-on: https://go-review.googlesource.com/c/go/+/191198
    Run-TryBot: Keith Randall <khr@golang.org>
    TryBot-Result: Gobot Gobot <gobot@golang.org>
    Reviewed-by: default avatarMartin Möhrmann <moehrmann@google.com>
    36f30ba2
recover2.go 1.22 KB