• Keith Randall's avatar
    runtime: fix ppc64le race code · 44e752c3
    Keith Randall authored
    This code is not currently compiling, the asm vet checks fail. When running race.bash on ppc64le, I get:
    
    runtime/race_ppc64le.s:104:1: [ppc64le] RaceReadRange: wrong argument size 24; expected $...-16
    runtime/race_ppc64le.s:514:1: [ppc64le] racecallbackthunk: unknown variable cmd; offset 0 is arg+0(FP)
    runtime/race_ppc64le.s:515:1: [ppc64le] racecallbackthunk: unknown variable ctx
    
    I'm also not sure why it ever worked; it looks like it is writing
    the arguments to racecallback in the wrong place (the race detector
    itself probably still works, it would just have trouble symbolizing
    any resulting race report).
    
    At a meta-level, we should really add a ppc64le/race builder.
    Otherwise this code will rot, as evidenced by the rot this CL fixes :)
    
    Update #33309
    
    Change-Id: I3b49c2442aa78538fbb631a143a757389a1368fd
    Reviewed-on: https://go-review.googlesource.com/c/go/+/197337
    Run-TryBot: Keith Randall <khr@golang.org>
    Reviewed-by: default avatarBrad Fitzpatrick <bradfitz@golang.org>
    Reviewed-by: default avatarLynn Boger <laboger@linux.vnet.ibm.com>
    TryBot-Result: Gobot Gobot <gobot@golang.org>
    44e752c3
race_ppc64le.s 17.8 KB