• Huan Du's avatar
    reflect: fix panic in DeepEqual when checking a cycle · 4dc11ae2
    Huan Du authored
    Before this change, when DeepEqual checks values with cycle, it may
    panic due to stack overflow.
    
    Here is a sample to reproduce the issue.
    
        makeCycleMap := func() interface{} {
            cycleMap := map[string]interface{}{}
            cycleMap["foo"] = cycleMap
            return cycleMap
        }
    
        m1 := makeCycleMap()
        m2 := makeCycleMap()
        reflect.DeepEqual(m1, m2) // stack overflow
    
    The root cause is that DeepEqual fails to cache interface values
    in visited map, which is used to detect cycle. DeepEqual calls
    CanAddr to check whether a value should be cached or not. However,
    all values referenced by interface don't have flagAddr thus all these
    values are not cached.
    
    THe fix is to remove CanAddr calls and use underlying ptr in value
    directly. As ptr is only read-only in DeepEqual for caching, it's
    safe to do so. We don't use UnsafeAddr this time, because this method
    panics when CanAddr returns false.
    
    Fixes #33907
    
    Change-Id: I2aa88cc060a2c2192b1d34c129c0aad4bd5597e7
    Reviewed-on: https://go-review.googlesource.com/c/go/+/191940
    Run-TryBot: Ian Lance Taylor <iant@golang.org>
    TryBot-Result: Gobot Gobot <gobot@golang.org>
    Reviewed-by: default avatarIan Lance Taylor <iant@golang.org>
    4dc11ae2
all_test.go 173 KB