• Robert Griesemer's avatar
    cmd/compile: towards simpler and faster lexing: always use getr · 539aa05a
    Robert Griesemer authored
    Always reading runes (rather than bytes) has negligible overhead
    (a simple if at the moment - it can be eliminated eventually) but
    simplifies the lexer logic and opens up the door for speedups.
    In the process remove many int conversions that are now not needed
    anymore.
    
    Also, because identifiers are now more easily recognized, remove
    talph label and move identifier lexing "in place".
    
    Also, instead of accepting all chars < 0x80 and then check for
    "frogs", only permit valid characters in the first place. Removes
    an extra call for common simple tokens and leads to simpler logic.
    
    `time go build -a net/http` (best of 5 runs) seems 1% faster.
    Assuming this is in the noise, there is no noticeable performance
    degradation with this change.
    
    Change-Id: I3454c9bf8b91808188cf7a5f559341749da9a1eb
    Reviewed-on: https://go-review.googlesource.com/19847Reviewed-by: default avatarMatthew Dempsky <mdempsky@google.com>
    Run-TryBot: Robert Griesemer <gri@golang.org>
    TryBot-Result: Gobot Gobot <gobot@golang.org>
    539aa05a
lex.go 48.5 KB