• Matthew Dempsky's avatar
    cmd/compile: rewrite untyped constant conversion logic · 581526ce
    Matthew Dempsky authored
    This CL detangles the hairy mess that was convlit+defaultlit. In
    particular, it makes the following changes:
    
    1. convlit1 now follows the standard typecheck behavior of setting
    "n.Type = nil" if there's an error. Notably, this means for a lot of
    test cases, we now avoid reporting useless follow-on error messages.
    For example, after reporting that "1 << s + 1.0" has an invalid shift,
    we no longer also report that it can't be assigned to string.
    
    2. Previously, assignconvfn had some extra logic for trying to
    suppress errors from convlit/defaultlit so that it could provide its
    own errors with better context information. Instead, this extra
    context information is now passed down into convlit1 directly.
    
    3. Relatedly, this CL also removes redundant calls to defaultlit prior
    to assignconv. As a consequence, when an expression doesn't make sense
    for a particular assignment (e.g., assigning an untyped string to an
    integer), the error messages now say "untyped string" instead of just
    "string". This is more consistent with go/types behavior.
    
    4. defaultlit2 is now smarter about only trying to convert pairs of
    untyped constants when it's likely to succeed. This allows us to
    report better error messages for things like 3+"x"; instead of "cannot
    convert 3 to string" we now report "mismatched types untyped number
    and untyped string".
    
    Passes toolstash-check.
    
    Change-Id: I26822a02dc35855bd0ac774907b1cf5737e91882
    Reviewed-on: https://go-review.googlesource.com/c/go/+/187657
    Run-TryBot: Matthew Dempsky <mdempsky@google.com>
    TryBot-Result: Gobot Gobot <gobot@golang.org>
    Reviewed-by: default avatarRobert Griesemer <gri@golang.org>
    581526ce
ddd1.go 1.56 KB