• LE Manh Cuong's avatar
    time: fix misleading error with the leading zero format · 8feeada5
    LE Manh Cuong authored
    When the leading zero format is used, we currently don't handle the
    month and year properly.
    
    For the month, we were reporting an out of range error when getnum
    returns zero of its own, as it also returns the month 0. That's
    confusing, so only check the range when getnum returns a nil error.
    
    For the year, we don't restore the value when parsing error occurs. For
    example, with the incorrect input "111-01", "01" will be used to report
    an error. So restore the value when an error occurs fix the problem.
    
    Fixes #29918
    Fixes #29916
    
    Change-Id: I3145f8c46813a0457766b7c302482e6b56f94ed6
    Reviewed-on: https://go-review.googlesource.com/c/go/+/160338
    Run-TryBot: Ian Lance Taylor <iant@golang.org>
    TryBot-Result: Gobot Gobot <gobot@golang.org>
    Reviewed-by: default avatarIan Lance Taylor <iant@golang.org>
    8feeada5
format.go 41.5 KB