• David Crawshaw's avatar
    cmd/link: correctly decode name length · 96b8f70e
    David Crawshaw authored
    The linker was incorrectly decoding type name lengths, causing
    typelinks to be sorted out of order and in cases where the name was
    the exact right length, linker panics.
    
    Added a test to the reflect package that causes TestTypelinksSorted
    to fail before this CL. It's not the exact failure seen in #15448
    but it has the same cause: decodetype_name calculating the wrong
    length.
    
    The equivalent decoders in reflect/type.go and runtime/type.go
    have the parenthesis in the right place.
    
    Fixes #15448
    
    Change-Id: I33257633d812b7d2091393cb9d6cc8a73e0138c8
    Reviewed-on: https://go-review.googlesource.com/22403Reviewed-by: default avatarBrad Fitzpatrick <bradfitz@golang.org>
    Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
    Reviewed-by: default avatarRuss Cox <rsc@golang.org>
    TryBot-Result: Gobot Gobot <gobot@golang.org>
    96b8f70e
all_test.go 144 KB