• Michael Anthony Knyszek's avatar
    runtime: redefine scavenge goal in terms of heap_inuse · 9b308112
    Michael Anthony Knyszek authored
    This change makes it so that the scavenge goal is defined primarily in
    terms of heap_inuse at the end of the last GC rather than next_gc. The
    reason behind this change is that next_gc doesn't take into account
    fragmentation, and we can fall into situation where the scavenger thinks
    it should have work to do but there's no free and unscavenged memory
    available.
    
    In order to ensure the scavenge goal still tracks next_gc, we multiply
    heap_inuse by the ratio between the current heap goal and the last heap
    goal, which describes whether the heap is growing or shrinking, and by
    how much.
    
    Finally, this change updates the documentation for scavenging and
    elaborates on why the scavenge goal is defined the way it is.
    
    Fixes #34048.
    Updates #32828.
    
    Change-Id: I8deaf87620b5dc12a40ab8a90bf27932868610da
    Reviewed-on: https://go-review.googlesource.com/c/go/+/193040
    Run-TryBot: Michael Knyszek <mknyszek@google.com>
    TryBot-Result: Gobot Gobot <gobot@golang.org>
    Reviewed-by: default avatarAustin Clements <austin@google.com>
    Reviewed-by: default avatarKeith Randall <khr@golang.org>
    9b308112
mstats.go 22.4 KB