• Daniel Martí's avatar
    encoding/json: remove unnecessary isValidNumber call · ae68a912
    Daniel Martí authored
    The decoder called this function to check numbers being decoded into a
    json.Number. However, these can't be quoted as strings, so the tokenizer
    has already verified they are valid JSON numbers.
    
    Verified this by adding a test with such an input. As expected, it
    produces a syntax error, not the fmt.Errorf - that line could never
    execute.
    
    Since the only remaining non-test caller of isvalidnumber is in
    encode.go, move the function there.
    
    This change should slightly reduce the amount of work when decoding into
    json.Number, though that isn't very common nor part of any current
    benchmarks.
    
    Change-Id: I67a1723deb3d18d5b542d6dd35f3ae56a43f23eb
    Reviewed-on: https://go-review.googlesource.com/c/go/+/184817
    Run-TryBot: Daniel Martí <mvdan@mvdan.cc>
    Reviewed-by: default avatarBrad Fitzpatrick <bradfitz@golang.org>
    TryBot-Result: Gobot Gobot <gobot@golang.org>
    ae68a912
encode.go 35.6 KB