• Michael Hudson-Doyle's avatar
    cmd/link: re-use duplicate symbol object · b6fe2c2c
    Michael Hudson-Doyle authored
    Nothing cares about it.
    
    I did this after looking at the memprof output, but it helps performance a bit:
    
    name       old s/op    new s/op    delta
    LinkCmdGo   0.44 ± 3%   0.43 ± 3%  -2.20%   (p=0.000 n=94+90)
    LinkJuju    3.98 ± 5%   3.94 ± 5%  -1.19%  (p=0.000 n=100+91)
    
    As well as MaxRSS (i.e. what /usr/bin/time -f '%M' prints):
    
    name       old MaxRSS  new MaxRSS  delta
    LinkCmdGo   130k ± 0%   120k ± 3%  -7.79%   (p=0.000 n=79+90)
    LinkJuju    862k ± 6%   827k ± 8%  -4.01%  (p=0.000 n=100+99)
    
    Change-Id: I6306b7b3369576a688659e2ecdb0815b4152ae96
    Reviewed-on: https://go-review.googlesource.com/20972
    Run-TryBot: Michael Hudson-Doyle <michael.hudson@canonical.com>
    Reviewed-by: default avatarBrad Fitzpatrick <bradfitz@golang.org>
    b6fe2c2c
objfile.go 10.6 KB