• Matthew Dempsky's avatar
    cmd/compile: rewrite f(g()) for multi-value g() during typecheck · d96b7fbf
    Matthew Dempsky authored
    This CL moves order.go's copyRet logic for rewriting f(g()) into t1,
    t2, ... = g(); f(t1, t2, ...) earlier into typecheck. This allows the
    rest of the compiler to stop worrying about multi-value functions
    appearing outside of OAS2FUNC nodes.
    
    This changes compiler behavior in a few observable ways:
    
    1. Typechecking error messages for builtin functions now use general
    case error messages rather than unnecessarily differing ones.
    
    2. Because f(g()) is rewritten before inlining, saved inline bodies
    now see the rewritten form too. This could be addressed, but doesn't
    seem worthwhile.
    
    3. Most notably, this simplifies escape analysis and fixes a memory
    corruption issue in esc.go. See #29197 for details.
    
    Fixes #15992.
    Fixes #29197.
    
    Change-Id: I86a70668301efeec8fbd11fe2d242e359a3ad0af
    Reviewed-on: https://go-review.googlesource.com/c/153841Reviewed-by: default avatarRobert Griesemer <gri@golang.org>
    d96b7fbf
esc.go 68.7 KB