• David Chase's avatar
    cmd/compile: attempt to deflake debug_test.go · e45e4902
    David Chase authored
    Excluded when -short because it still runs relatively long,
    but deflaked.
    
    Removed timeouts from normal path and ensured that they were
    not needed and that reference files did not change.
    
    Use "tbreak" instead of "break" with gdb to reduce chance
    of multiple hits on main.main.  (Seems not enough, but a
    move in the right direction).
    
    By default, testing ignores repeated lines that occur when
    nexting.  This appears to sometimes be timing-dependent and
    is the observed source of flakiness in testing so far.
    Note that these can also be signs of a bug in the generated
    debugging output, but it is one of the less-confusing bugs
    that can occur.
    
    By default, testing with gdb uses compilation with
    inlining disabled to prevent dependence on library code
    (it's a bug that library code is seen while Nexting, but
    the bug is current behavior).
    
    Also by default exclude all source files outside /testdata
    to prevent accidental dependence on library code.  Note that
    this is currently only applicable to dlv because (for the
    debugging information we produce) gdb does not indicate a
    change in the source file for inlined code.
    
    Added flags -i and -r to make gdb testing compile with
    inlining and be sensitive to repeats in the next stream.
    This is for developer-testing and so we can describe these
    problems in bug reports.
    
    Updates #22206.
    
    Change-Id: I9a30ebbc65aa0153fe77b1858cf19743bdc985e4
    Reviewed-on: https://go-review.googlesource.com/69930
    Run-TryBot: David Chase <drchase@google.com>
    TryBot-Result: Gobot Gobot <gobot@golang.org>
    Reviewed-by: default avatarRuss Cox <rsc@golang.org>
    Reviewed-by: default avatarIan Lance Taylor <iant@golang.org>
    e45e4902
debug_test.go 23.9 KB