• Matthew Dempsky's avatar
    cmd/compile: omit ICE diagnostics after normal error messages · f3d4ff7d
    Matthew Dempsky authored
    After we detect errors, the AST is in a precarious state and more
    likely to trip useless ICE failures. Instead let the user fix any
    existing errors and see if the ICE persists.  This makes Fatalf more
    consistent with how panics are handled by hidePanic.
    
    While here, also fix detection for release versions: release version
    strings begin with "go" ("go1.8", "go1.9.1", etc), not "release".
    
    Fixes #22252.
    
    Change-Id: I1c400af62fb49dd979b96e1bf0fb295a81c8b336
    Reviewed-on: https://go-review.googlesource.com/70850
    Run-TryBot: Matthew Dempsky <mdempsky@google.com>
    TryBot-Result: Gobot Gobot <gobot@golang.org>
    Reviewed-by: default avatarRuss Cox <rsc@golang.org>
    f3d4ff7d
subr.go 46.4 KB