• Brad Fitzpatrick's avatar
    net: fix plan9 after context change, propagate contexts more · f60fcca5
    Brad Fitzpatrick authored
    My previous https://golang.org/cl/22101 to add context throughout the
    net package broke Plan 9, which isn't currently tested (#15251).
    
    It also broke some old unsupported version of Windows (Windows 2000?)
    which doesn't have the ConnectEx function, but that was only found
    visually, since our minimum supported Windows version has ConnectEx.
    This change simplifies the Windows and deletes the non-ConnectEx code
    path.  Windows 2000 will work even less now, if it even worked
    before. Windows XP remains our minimum supported version.
    
    Specifically, the previous CL stopped using the "dial" function, which
    0intro noted:
    https://github.com/golang/go/issues/15333#issuecomment-210842761
    
    This CL removes the dial function instead and makes plan9's net
    implementation respect contexts, which likely fixes a number of
    t.Skipped tests. I'm leaving that to 0intro to investigate.
    
    In the process of propagating and respecting contexts for plan9, I had
    to change some signatures to add contexts to more places and ended up
    pushing contexts down into the Go-based DNS resolution as well,
    replacing the pure-Go DNS implementation's use of "timeout
    time.Duration" with a context instead.
    
    Updates #11932
    Updates #15328
    
    Fixes #15333
    
    Change-Id: I6ad1e62f38271cdd86b3f40921f2d0f23374936a
    Reviewed-on: https://go-review.googlesource.com/22144Reviewed-by: default avatarDavid du Colombier <0intro@gmail.com>
    Reviewed-by: default avatarMikio Hara <mikioh.mikioh@gmail.com>
    Reviewed-by: default avatarIan Lance Taylor <iant@golang.org>
    Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
    TryBot-Result: Gobot Gobot <gobot@golang.org>
    f60fcca5
lookup_windows.go 13 KB