Commit 00e6fc1e authored by Dmitriy Vyukov's avatar Dmitriy Vyukov

runtime: temporary weaken a check in test

Currently the test fails as:
$ go test -v -cpu 1,1,1,1 runtime -test.run=TestStack
stack_test.go:1584: Stack inuse: want 4194304, got 18446744073709547520

Update #7468

LGTM=rsc
R=golang-codereviews, bradfitz
CC=golang-codereviews, khr, rsc
https://golang.org/cl/74010043
parent b87c7729
...@@ -1576,7 +1576,9 @@ func TestStackMem(t *testing.T) { ...@@ -1576,7 +1576,9 @@ func TestStackMem(t *testing.T) {
if consumed > estimate { if consumed > estimate {
t.Fatalf("Stack mem: want %v, got %v", estimate, consumed) t.Fatalf("Stack mem: want %v, got %v", estimate, consumed)
} }
inuse := s1.StackInuse - s0.StackInuse // Due to broken stack memory accounting (http://golang.org/issue/7468),
// StackInuse can decrease during function execution, so we cast the values to int64.
inuse := int64(s1.StackInuse) - int64(s0.StackInuse)
t.Logf("Inuse %vMB for stack mem", inuse>>20) t.Logf("Inuse %vMB for stack mem", inuse>>20)
if inuse > 4<<20 { if inuse > 4<<20 {
t.Fatalf("Stack inuse: want %v, got %v", 4<<20, inuse) t.Fatalf("Stack inuse: want %v, got %v", 4<<20, inuse)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment