Commit 023593d0 authored by Vladimir Stefanovic's avatar Vladimir Stefanovic Committed by Brad Fitzpatrick

runtime: enable GDB tests on mips64 (except TestGdbPythonCgo)

They were failing when run on 32bit RFS, with 32bit gdb.
(mips64 builder now has 64bit RFS, with gdb 7.9.)
Leaving TestGdbPythonCgo disabled, it behaves as described in #18784.

Fixes #18173

Change-Id: I3c438cd5850b7bfd118ac6396f40c1208bac8c2d
Reviewed-on: https://go-review.googlesource.com/45874Reviewed-by: default avatarCherry Zhang <cherryyz@google.com>
Run-TryBot: Cherry Zhang <cherryyz@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
parent e7c650bc
...@@ -91,16 +91,13 @@ func TestGdbPython(t *testing.T) { ...@@ -91,16 +91,13 @@ func TestGdbPython(t *testing.T) {
} }
func TestGdbPythonCgo(t *testing.T) { func TestGdbPythonCgo(t *testing.T) {
if runtime.GOARCH == "mips" || runtime.GOARCH == "mipsle" { if runtime.GOARCH == "mips" || runtime.GOARCH == "mipsle" || runtime.GOARCH == "mips64" {
testenv.SkipFlaky(t, 18784) testenv.SkipFlaky(t, 18784)
} }
testGdbPython(t, true) testGdbPython(t, true)
} }
func testGdbPython(t *testing.T, cgo bool) { func testGdbPython(t *testing.T, cgo bool) {
if runtime.GOARCH == "mips64" {
testenv.SkipFlaky(t, 18173)
}
if cgo && !build.Default.CgoEnabled { if cgo && !build.Default.CgoEnabled {
t.Skip("skipping because cgo is not enabled") t.Skip("skipping because cgo is not enabled")
} }
...@@ -258,9 +255,6 @@ func TestGdbBacktrace(t *testing.T) { ...@@ -258,9 +255,6 @@ func TestGdbBacktrace(t *testing.T) {
if runtime.GOOS == "netbsd" { if runtime.GOOS == "netbsd" {
testenv.SkipFlaky(t, 15603) testenv.SkipFlaky(t, 15603)
} }
if runtime.GOARCH == "mips64" {
testenv.SkipFlaky(t, 18173)
}
t.Parallel() t.Parallel()
checkGdbEnvironment(t) checkGdbEnvironment(t)
...@@ -332,10 +326,6 @@ func main() { ...@@ -332,10 +326,6 @@ func main() {
// TestGdbAutotmpTypes ensures that types of autotmp variables appear in .debug_info // TestGdbAutotmpTypes ensures that types of autotmp variables appear in .debug_info
// See bug #17830. // See bug #17830.
func TestGdbAutotmpTypes(t *testing.T) { func TestGdbAutotmpTypes(t *testing.T) {
if runtime.GOARCH == "mips64" {
testenv.SkipFlaky(t, 18173)
}
t.Parallel() t.Parallel()
checkGdbEnvironment(t) checkGdbEnvironment(t)
checkGdbVersion(t) checkGdbVersion(t)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment