Commit 070e2dda authored by Bryan C. Mills's avatar Bryan C. Mills

cmd/go/internal/modfetch/codehost: don't try to execute a nonexistent fetch function

This fixes a panic observed in
https://build.golang.org/log/1242a032cac29fd3dffb24055fdeff0202b546be.

Change-Id: I029b9d69cabb87091734bd33d7fd39d30b12f9c5
Reviewed-on: https://go-review.googlesource.com/c/go/+/183917Reviewed-by: default avatarJay Conrod <jayconrod@google.com>
parent 4047f01d
......@@ -341,7 +341,9 @@ func (r *vcsRepo) Stat(rev string) (*RevInfo, error) {
}
func (r *vcsRepo) fetch() {
_, r.fetchErr = Run(r.dir, r.cmd.fetch)
if len(r.cmd.fetch) > 0 {
_, r.fetchErr = Run(r.dir, r.cmd.fetch)
}
}
func (r *vcsRepo) statLocal(rev string) (*RevInfo, error) {
......
......@@ -13,6 +13,12 @@ stderr 'ReadZip not implemented for svn'
! go install .
stderr 'ReadZip not implemented for svn'
# Attempting to get a nonexistent module using svn should fail with a
# reasonable message instead of a panic.
! go get -d vcs-test.golang.org/svn/nonexistent.svn
! stderr panic
stderr 'go get vcs-test.golang.org/svn/nonexistent.svn: no matching versions for query "latest"'
-- go.mod --
module golang/go/issues/28943/main
-- main.go --
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment