Commit 0af302f5 authored by Brad Fitzpatrick's avatar Brad Fitzpatrick

time: add Time.FormatAppend

This is a version of Time.Format that doesn't require allocation.

Fixes #5192
Update #5195

R=r
CC=gobot, golang-dev
https://golang.org/cl/8478044
parent f7b5a019
...@@ -380,6 +380,22 @@ func (t Time) String() string { ...@@ -380,6 +380,22 @@ func (t Time) String() string {
// about the formats and the definition of the reference time, see the // about the formats and the definition of the reference time, see the
// documentation for ANSIC and the other constants defined by this package. // documentation for ANSIC and the other constants defined by this package.
func (t Time) Format(layout string) string { func (t Time) Format(layout string) string {
const bufSize = 64
var b []byte
max := len(layout) + 10
if max <= bufSize {
var buf [bufSize]byte
b = buf[:0]
} else {
b = make([]byte, 0, max)
}
b = t.FormatAppend(layout, b)
return string(b)
}
// FormatAppend works like Format but appends the textual
// representation to b and returns the extended buffer.
func (t Time) FormatAppend(layout string, b []byte) []byte {
var ( var (
name, offset, abs = t.locabs() name, offset, abs = t.locabs()
...@@ -389,16 +405,7 @@ func (t Time) Format(layout string) string { ...@@ -389,16 +405,7 @@ func (t Time) Format(layout string) string {
hour int = -1 hour int = -1
min int min int
sec int sec int
b []byte
buf [64]byte
) )
max := len(layout) + 10
if max <= len(buf) {
b = buf[:0]
} else {
b = make([]byte, 0, max)
}
// Each iteration generates one std value. // Each iteration generates one std value.
for layout != "" { for layout != "" {
prefix, std, suffix := nextStdChunk(layout) prefix, std, suffix := nextStdChunk(layout)
...@@ -546,7 +553,7 @@ func (t Time) Format(layout string) string { ...@@ -546,7 +553,7 @@ func (t Time) Format(layout string) string {
b = formatNano(b, uint(t.Nanosecond()), std>>stdArgShift, std&stdMask == stdFracSecond9) b = formatNano(b, uint(t.Nanosecond()), std>>stdArgShift, std&stdMask == stdFracSecond9)
} }
} }
return string(b) return b
} }
var errBad = errors.New("bad value for field") // placeholder not passed to user var errBad = errors.New("bad value for field") // placeholder not passed to user
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment