Commit 1206e974 authored by Ian Lance Taylor's avatar Ian Lance Taylor

cmd/go: don't use a testlog if there is an exec command

An exec command is normally used on platforms were the test is run in
some unusual way, making it less likely that the testlog will be useful.

Updates #22593

Change-Id: I0768f6da89cb559d8d675fdf6d685db9ecedab9e
Reviewed-on: https://go-review.googlesource.com/83578
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: default avatarBrad Fitzpatrick <bradfitz@golang.org>
parent 132b528e
......@@ -1265,11 +1265,12 @@ func (c *runCache) builderRunTest(b *work.Builder, a *work.Action) error {
return nil
}
execCmd := work.FindExecCmd()
testlogArg := []string{}
if !c.disableCache && cfg.Goos != "nacl" {
if !c.disableCache && len(execCmd) == 0 {
testlogArg = []string{"-test.testlogfile=" + a.Objdir + "testlog.txt"}
}
args := str.StringList(work.FindExecCmd(), a.Deps[0].Target, testlogArg, testArgs)
args := str.StringList(execCmd, a.Deps[0].Target, testlogArg, testArgs)
if testCoverProfile != "" {
// Write coverage to temporary profile, for merging later.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment