cmd/gc: slightly better code generation

* Avoid treating CALL fn(SB) as justification for introducing
and tracking a registerized variable for fn(SB).

* Remove USED(n) after declaration and zeroing of n.
It was left over from when the compiler emitted more
aggressive set and not used errors, and it was keeping
the optimizer from removing a redundant zeroing of n
when n was a pointer or integer variable.

Update #597.

R=ken2
CC=golang-dev
https://golang.org/cl/7277048

src/cmd/5g/reg.c

@@ -275,6 +275,10 @@ regopt(Prog *firstp)
 			}
 		}
 
+		// Avoid making variables for direct-called functions.
+		if(p->as == ABL && p->to.type == D_EXTERN)
+			continue;
+
 		/*
 		 * left side always read
 		 */

src/cmd/6g/reg.c

@@ -252,6 +252,10 @@ regopt(Prog *firstp)
 			}
 		}
 
+		// Avoid making variables for direct-called functions.
+		if(p->as == ACALL && p->to.type == D_EXTERN)
+			continue;
+
 		// Addressing makes some registers used.
 		if(p->from.type >= D_INDIR)
 			r->use1.b[0] |= RtoB(p->from.type-D_INDIR);

src/cmd/8g/reg.c

@@ -222,6 +222,10 @@ regopt(Prog *firstp)
 			}
 		}
 
+		// Avoid making variables for direct-called functions.
+		if(p->as == ACALL && p->to.type == D_EXTERN)
+			continue;
+
 		// Addressing makes some registers used.
 		if(p->from.type >= D_INDIR)
 			r->use1.b[0] |= RtoB(p->from.type-D_INDIR);

src/cmd/gc/gen.c

@@ -735,8 +735,6 @@ cgen_as(Node *nl, Node *nr)
 			return;
 		}
 		clearslim(nl);
-		if(nl->addable)
-			gused(nl);
 		return;
 	}